Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements global prompt files sync logic #241123

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Conversation

legomushroom
Copy link
Member

@legomushroom legomushroom commented Feb 18, 2025

For #13087.
Depends on PR#850.

@legomushroom legomushroom added this to the February 2025 milestone Feb 18, 2025
@legomushroom legomushroom self-assigned this Feb 18, 2025
@legomushroom legomushroom changed the title Legomushroom/prompts/sync implements global prompts sync logic Feb 18, 2025
@legomushroom legomushroom force-pushed the legomushroom/prompts/sync branch from 1854d21 to a895d83 Compare February 18, 2025 19:46
@legomushroom
Copy link
Member Author

Hey @sandy081 👋 Requested a review from you sine the bulk of the new PromptsSync class was copied over from the SnippetsSync one.

Did that to make the ball rolling, but would be good to sync up with you for unifying these two. Happy to do that refactor in a subsequent PR if you won't object 🤗

lszomoru
lszomoru previously approved these changes Feb 18, 2025
@lszomoru
Copy link
Member

@legomushroom, the PR build is 🔴

@legomushroom legomushroom force-pushed the legomushroom/prompts/sync branch from a895d83 to b08b40e Compare February 18, 2025 20:22
@legomushroom legomushroom force-pushed the legomushroom/prompts/sync branch from a3bcef3 to 5218484 Compare February 18, 2025 22:06
@legomushroom legomushroom changed the title implements global prompts sync logic implements global prompt files sync logic Feb 18, 2025
@legomushroom legomushroom force-pushed the legomushroom/prompts/sync branch from 3bb4e84 to 3968937 Compare February 18, 2025 22:46
@legomushroom legomushroom force-pushed the legomushroom/prompts/sync branch from 3968937 to edc5e33 Compare February 19, 2025 15:43
@legomushroom legomushroom requested review from lszomoru and removed request for sandy081 February 19, 2025 19:44
@legomushroom legomushroom merged commit 30ca77e into main Feb 19, 2025
8 checks passed
@legomushroom legomushroom deleted the legomushroom/prompts/sync branch February 19, 2025 19:55
@glektarssza
Copy link

This PR completely breaks setting sync for me, at least within GitHub Codespaces.

broken_codespace.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants