Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✋ 🆙 [email protected] #240995

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

✋ 🆙 [email protected] #240995

wants to merge 2 commits into from
+108 −29

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Feb 17, 2025

No description provided.

@bpasero bpasero self-assigned this Feb 17, 2025
@bpasero bpasero enabled auto-merge (squash) February 17, 2025 11:07
@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 17, 2025
@bpasero
Copy link
Member Author

bpasero commented Feb 17, 2025

Turns out we still depend on the non-ESM variant here:

vscode/scripts/code-server.js

Line 10 in 099de6d

const open = require('open');

and

vscode/scripts/code-web.js

Line 17 in 099de6d

const open = require('open');

fyi @aeschli

@bpasero bpasero marked this pull request as draft February 17, 2025 11:45
auto-merge was automatically disabled February 17, 2025 11:45

Pull request was converted to draft

@bpasero bpasero changed the title 🆙 [email protected] ✋ 🆙 [email protected] Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@bpasero @joaomoreno