ensure spec and builtin commands show up before misc ones #240724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Feb 13, 2025
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionModel.ts
Outdated
Show resolved
Hide resolved
Tyriar
previously requested changes
Feb 14, 2025
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionModel.ts
Outdated
Show resolved
Hide resolved
meganrogge
force-pushed
the
merogge/sort-order
branch
from
a6e13ab to
5f7cf3b
Compare
meganrogge
changed the title
Tyriar
requested changes
Feb 18, 2025
meganrogge
commented
Feb 18, 2025
Tyriar
previously approved these changes
Feb 18, 2025
src/vs/workbench/services/suggest/browser/simpleSuggestWidget.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Feb 19, 2025
| @@ -8,20 +8,20 @@ import cdSpec from '../../completions/cd'; | |||
| import { testPaths, type ISuiteSpec } from '../helpers'; | |||
|
|
|||
| const expectedCompletions = ['-']; | |||
|
|
|||
| const cdExpectedCompletions = [{ label: 'cd', description: (cdSpec as any).description }]; | |||
There was a problem hiding this comment.
@Tyriar fyi these as any casts were needed bc it said description did not exist on fig.spec, which makes no sense
rebornix
previously approved these changes
Feb 19, 2025
roblourens
approved these changes
Feb 19, 2025
karthiknadig
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #239977
Screen.Recording.2025-02-14.at.2.50.24.PM.mov