Better handle shell env api usage for windows conpty #240710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
changed the title
Tyriar
requested changes
Feb 18, 2025
Tyriar
requested changes
Feb 18, 2025
| @@ -87,8 +87,17 @@ export function getShellIntegrationInjection( | |||
| if (options.shellIntegration.nonce) { | |||
| envMixin['VSCODE_NONCE'] = options.shellIntegration.nonce; | |||
| } | |||
|
|
|||
| const enableWindowsEnvReporting = options.windowsUseConptyDll || options.windowsEnableConpty && getWindowsBuildNumber() >= 22631; | |||
There was a problem hiding this comment.
Let's stick this inside the isWindows block to avoid unnecessary work
There was a problem hiding this comment.
Just like this, right?
Tyriar
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve: #237900
and better handle env api usage for windows, conptydll related.