-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface for adding value selection in QuickPick for extension API #233275
Add interface for adding value selection in QuickPick for extension API #233275
Conversation
We should have this be a property Keep in mind, since this requires API proposal, we will discuss this internally. However, this feels small and provides value so I think this will be a good addition. |
fb751b3
to
4ad5865
Compare
Sure, no problem discussing this. I changed the interface. To be honest I feel that this should be the property of Also sorry for accidentally closing the PR, I accidentally force-pushed this branch to the current |
Yes, I think on |
Sure, I've changed this to have |
Our API review meeting brought up a good point that |
Sorry, I think I misunderstand something. What change do you propose? Right now |
vscode/src/vscode-dts/vscode.d.ts Line 12649 in beaa10f
It is, however, in vscode/src/vscode-dts/vscode.d.ts Line 12734 in beaa10f
and vscode/src/vscode-dts/vscode.d.ts Line 12826 in beaa10f
We want |
Ah sorry, got it. You were talking about the exposed API, rather than the implementation. Agree that in that case we should have valueSelection added only to QuickPick. Will do |
This comment has been minimized.
This comment has been minimized.
Sure, I've done that. Let me know if you think that implementation of |
Thanks for working on this @CrafterKolyan! So the timeline for this is:
|
Fixes #233274
Adding interface to
setValueSelection
inQuickInput
for extensions.I am also fine with creating property
valueSelection
like this:vscode/src/vscode-dts/vscode.d.ts
Lines 12828 to 12837 in 818169a
though it looks to me that having a functon
setValueSelection
explicitly documents the fact that you can't readvalueSelection
property for the current user selection.The best implementation in my opinion should be
valueSelection
property that is also updated with user selection, though for my use case justsetValueSelection
works. Ready to reimplement it to any of these two cases.Will probably change it to
valueSelection
any way as I think that means literally zero code from my side apart from exposing the already existing API.