Add interface for adding value selection in QuickInput for extension API #233275
+34
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233274
Adding interface to
setValueSelection
inQuickInput
for extensions.I am also fine with creating property
valueSelection
like this:vscode/src/vscode-dts/vscode.d.ts
Lines 12828 to 12837 in 818169a
though it looks to me that having a functon
setValueSelection
explicitly documents the fact that you can't readvalueSelection
property for the current user selection.The best implementation in my opinion should be
valueSelection
property that is also updated with user selection, though for my use case justsetValueSelection
works. Ready to reimplement it to any of these two cases.Will probably change it to
valueSelection
any way as I think that means literally zero code from my side apart from exposing the already existing API.