make terminal suggest addon more generic #233013
Open
+2,343
−1,725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Imms <[email protected]>
Tyriar
reviewed
Nov 8, 2024
src/vs/workbench/contrib/terminalContrib/suggest/browser/pwshCompletionProviderAddon.ts
Outdated
Show resolved
Hide resolved
|
the |
That one's static to share across all terminals, since not having cached commands can lock up the terminal for potentially seconds |
This reverts commit 88ed821.
Tyriar
reviewed
Nov 8, 2024
...rkbench/contrib/terminalContrib/suggest/test/browser/terminalSuggestAddon.integrationTest.ts
Outdated
Show resolved
Hide resolved
Tyriar
reviewed
Nov 8, 2024
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts
Outdated
Show resolved
Hide resolved
meganrogge
force-pushed
the
merogge/start-terminal-suggest
branch
from
f3a649d
to
19a1981
Compare
Tyriar
previously requested changes
Nov 8, 2024
src/vs/workbench/contrib/terminalContrib/suggest/browser/pwshCompletionProviderAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/pwshCompletionProviderAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/pwshCompletionProviderAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/pwshCompletionProviderAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/pwshCompletionProviderAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts
Outdated
Show resolved
Hide resolved
| return; | ||
| } | ||
| this._lastAcceptedCompletionTimestamp = Date.now(); | ||
| SuggestAddon.lastAcceptedCompletionTimestamp = Date.now(); |
There was a problem hiding this comment.
We don't want this to be static as it's intentionally tracked per suggest addon. It's unlikely to cause a problem if it were static, but it makes the code a bit harder to understand being static imo.
There was a problem hiding this comment.
this is referenced in the pwshAddon
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts
Outdated
Show resolved
Hide resolved
...rkbench/contrib/terminalContrib/suggest/test/browser/terminalSuggestAddon.integrationTest.ts
Outdated
Show resolved
Hide resolved
Tyriar
reviewed
Nov 8, 2024
src/vs/workbench/contrib/terminalContrib/suggest/browser/pwshCompletionProviderAddon.ts
Outdated
Show resolved
Hide resolved
…nalSuggestAddon.ts Co-authored-by: Daniel Imms <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #233364