Implement new find functionality in Explorer view #232964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
previously requested changes
Nov 7, 2024
| try { | ||
| node = this.getDataNode(element); | ||
| } catch { | ||
| console.log('Error in _updateChildren'); |
There was a problem hiding this comment.
This is a bad idea. If this happens, the tree will be in a very bad state and there's no recovering from here. So we want the error to be thrown instead of quietly logging and pretending everything is fine.
There was a problem hiding this comment.
If this indeed is something that is happening, we must dig into the root cause and fix the issue upstream.
There was a problem hiding this comment.
Thanks for catching this, I added it for debugging reasons but forgot to remove it.
DonJayamanne
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce methods for marking and unmarking items as find results, along with a mechanism to prevent refreshing the view when phantom elements are present. Additionally, add a context key to indicate when the find provider is active.
fixes #233185