Send normalized canonical path to debug adapter always #232791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #232088.
VS Code sends inconsistent paths across different setBreakpoints requests in the same session, in case the debug adapter sends differently cased path in Source as part of stack resolution or other responses. This is common in case insensitive file systems and can create issues for underlying debug adapter or debuggers like lldb.
We already normalize drive letter on Windows before sending it to debug adapter to be consistent. Extend this to normalize and use the canonical path for the entire path, instead of just normalizing the drive letter. This makes different setBreakpoints requests have consistent path string for the same path in case-insensitive file systems.