allows undo/redo pasted images in chat #232777
Conversation
| @@ -89,6 +92,19 @@ export class PasteImageProvider implements DocumentPasteEditProvider { | |||
|
|
|||
| widget.attachmentModel.addContext(imageContext); | |||
|
|
|||
| this.undoRedoService.pushElement({ | |||
There was a problem hiding this comment.
Let's see if we can move this into the BulkEditService. provideDocumentPasteEdits should not have any side effects, as this method may be called even if the edit is not actually applied yet
Here's what I'm thinking:
-
In our internal version of
WorkspaceEdit, add a new edit type called something likeICustomEdit -
ICustomEditwould be similar to the existingIWorkspaceUndoRedoElement. The main methods it would have areredoto apply the edit, and undo to undo it -
Then update the bulk edit service to handle this new type of edit. This is will be the most complicated part as an
ICustomEditwould need to work along side the normal text edits
@jrieken Does this sound like a reasonable proposal?
Two alternatives approaches :
-
If we'd prefer a more scoped fix, we could instead isolate this logic just to the copy paste controller so that
DocumentPasteEditcan either return aWorkspaceEditor a custom edit withundoandredo -
We could add an explicit
AddChatAttachmentedit type and make the bulk edit service know how to handle that
There was a problem hiding this comment.
I think both make sense. Adding a special workspace edit might be a bit more involed but could be the right thing in the long run (it will enable more undo-able things) but it is also a bit weird that the DocumentPasteEdit#insertText is empty then (tho less weird than today where it all relies on side effects)
can undo and redo pasted images
Screen.Recording.2024-10-31.at.5.03.48.PM.mov