Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll chat list on keyboard focus #232644

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

scroll chat list on keyboard focus #232644

wants to merge 9 commits into from

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Oct 30, 2024

@meganrogge meganrogge marked this pull request as draft October 30, 2024 17:57
@meganrogge meganrogge self-assigned this Oct 30, 2024
@meganrogge meganrogge added this to the November 2024 milestone Oct 30, 2024
@meganrogge meganrogge changed the title scroll on keyboard focus scroll chat list on keyboard focus Oct 30, 2024
@roblourens
Copy link
Member

Looks great, but it looks like it's scrolling even when tabbing to something inside the viewport? I don't think it should do that, and it would still scroll when clicking buttons and things, I think

@meganrogge
Copy link
Contributor Author

meganrogge commented Oct 31, 2024

Crux of the issue: scrollTop and y are wrong for elts below the viewport

@meganrogge meganrogge marked this pull request as ready for review November 1, 2024 04:07
@meganrogge meganrogge enabled auto-merge (squash) November 1, 2024 04:09
@meganrogge meganrogge marked this pull request as draft November 1, 2024 04:29
auto-merge was automatically disabled November 1, 2024 04:29

Pull request was converted to draft

@meganrogge meganrogge marked this pull request as ready for review November 1, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants