-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scroll chat list on keyboard focus #232644
Open
meganrogge
wants to merge
9
commits into
main
Choose a base branch
from
merogge/scroll-top
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
changed the title
scroll on keyboard focus
scroll chat list on keyboard focus
Oct 30, 2024
Looks great, but it looks like it's scrolling even when tabbing to something inside the viewport? I don't think it should do that, and it would still scroll when clicking buttons and things, I think |
meganrogge
force-pushed
the
merogge/scroll-top
branch
from
October 31, 2024 00:34
2c74354
to
a79c4e9
Compare
Crux of the issue: |
meganrogge
force-pushed
the
merogge/scroll-top
branch
from
November 1, 2024 04:06
36cc379
to
c775480
Compare
meganrogge
commented
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/microsoft/vscode-copilot/issues/9357
demo.mov