chore: upgrade Windows agents #232621
Open
chore: upgrade Windows agents #232621
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the cache https://github.com/microsoft/vscode/blob/main/build/.cachesalt and rerun to verify module dependencies build fine.
Native modules build with statically linked msvcrt and the runtime is prebuilt with statically linked libc++. If it builds fine and tests pass they will run on our current supported versions. |
rzhao271
force-pushed
the
rzhao271/upgrade-agents
branch
from
fb58c78
to
a47c411
Compare
|
New verification build https://dev.azure.com/monacotools/Monaco/_build/results?buildId=303586&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Windows agents to build native dependencies with VS 2022 as part of internal compliance requirements.
Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=302107&view=results
I'm unsure whether using a newer VS could cause issues for users on older versions of Windows.