Find in Outline View not working

[chrispy-snps]

The "Show Call Hierarchy" is an amazingly useful feature for understanding code structure! But sometimes it can display too much information.

Let's say I want to understand how Python's pprint.pprint() function works. If I perform the following steps:

1. Enter the following Python code in VSCode:

   import pprint
   
   pprint.pprint("hello world")

2. Right-click the pprint("hello world") function call and choose "Show Call Hierarchy".

3. Click the "Show Outgoing Calls" button at the top-right of the call history view:

   

I can explore the call hierarchy to get results as follows (apologies for length, but it's sort of the the point):

The functions and methods defined by the pprint module are in there, but they are obscured among a sea of Python built-in dataclass/typing/etc. entries.

It would be extremely useful to have some way to filter the results by scope and/or file.

[gjsjohnmurray]

Perhaps some upcoming improvements to the tree find feature (Ctrl+Alt+F) so it can filter on folder names, not just leaf names, may help here. Pinging @benibenj

[jrieken]

We do have find/filter in there but it looks like it's broken...

[chrispy-snps]

@jrieken - interesting, how did you get that dialog? It's not shown for me (at least not obviously).

[jrieken]

Ctrl+Alt+F (macOS: Cmd+Alt+F)

[chrispy-snps]

Thanks @jrieken! I did not know about that shortcut.

Unfortunately it appears to operate only on the item text, whereas the requested enhancement would need to consider information not shown in that text (class scope, file name, etc.).

[gjsjohnmurray]

it looks like it's broken...

The original tree find's filter mode displays unresolved folders regardless of whether or not their names match, so you can expand (i.e. resolve) them. When a non-matching folder has been resolved and contains no unresolved child folders it will get filtered out unless any of its leaf children match.

Recent work by @benibenj in the Explorer tree reworked this behaviour, but AFAIK (a) the new filtering only looks at leaf nodes (i.e. in the Explorer case, filenames), and (b) is (or maybe will be) an opt-in for other instances of the tree.

[benibenj]

The Outline view is not an async tree, meaning this should just work out of the box. There seems to be a bug which I have a fix for.

[chrispy-snps]

@benibenj - appreciate the fix, but how does this apply to filtering by scope (e.g., functions in the current file/class versus those in other files/classes or built-in functions?

[benibenj]

I created this feature request to handle your use case: #233394