refinement

microsoft · Nov 8, 2024 · b039f71 · b039f71
1 parent fedd59d
commit b039f71
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 27 deletions.
diff --git a/src/client/testing/testController/common/utils.ts b/src/client/testing/testController/common/utils.ts
@@ -169,28 +169,6 @@ export function pythonTestAdapterRewriteEnabled(serviceContainer: IServiceContai
     return experiment.inExperimentSync(EnableTestAdapterRewrite.experiment);
 }
 
-// export async function startTestIdsNamedPipe(testIds: string[]): Promise<string> {
-//     const pipeName: string = generateRandomPipeName('python-test-ids');
-//     // uses callback so the on connect action occurs after the pipe is created
-//     await createNamedPipeServer(pipeName, ([_reader, writer]) => {
-//         traceVerbose('Test Ids named pipe connected');
-//         // const num = await
-//         const msg = {
-//             jsonrpc: '2.0',
-//             params: testIds,
-//         } as Message;
-//         writer
-//             .write(msg)
-//             .then(() => {
-//                 writer.end();
-//             })
-//             .catch((ex) => {
-//                 traceError('Failed to write test ids to named pipe', ex);
-//             });
-//     });
-//     return pipeName;
-// }
-
 interface ExecutionResultMessage extends Message {
     params: ExecutionTestPayload;
 }

diff --git a/src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts b/src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts
@@ -45,11 +45,8 @@ export class PytestTestDiscoveryAdapter implements ITestDiscoveryAdapter {
             this.resultResolver?.resolveDiscovery(data);
         });
 
-        try {
-            await this.runPytestDiscovery(uri, name, executionFactory, interpreter);
-        } finally {
-            traceVerbose('donee');
-        }
+        await this.runPytestDiscovery(uri, name, executionFactory, interpreter);
+
         // this is only a placeholder to handle function overloading until rewrite is finished
         const discoveryPayload: DiscoveredTestPayload = { cwd: uri.fsPath, status: 'success' };
         return discoveryPayload;