[libressl] Fix GitHub download URL #42218
Conversation
The URL was missing the `$` in front of `{VERSION}`.
Remove warnings patch since its unnecessary.
JonLiu1993
added
the
category:port-bug
| FILENAME "${PORT}-${VERSION}.tar.gz" | ||
| SHA512 b5ec6d1f4e3842ecb487f9a67d86db658d05cbe8cd3fcba61172affa8c65c5d0823aa244065a7233f06c669d04a5a36517c02a2d99d2f2da3c4df729ac243b37 | ||
| ) | ||
|
|
||
| vcpkg_download_distfile(WARNINGS_REMOVAL_PATCH |
There was a problem hiding this comment.
Can you explain why you removed this patch?
There was a problem hiding this comment.
Sounded like @dg0yt wanted it removed but it was merged before I got to it.
see #42145 (review)
There was a problem hiding this comment.
The patch isn't to fix some warning that fails under /WX?
If the warning just ends up in logs that nobody cares about, then sure, it has no real reason to be here, but I'm assuming if it went to a long forlorn and forgotten text file that someone wouldn't have taken the effort to backport it.
There was a problem hiding this comment.
Nope /WX is not present.
I’ve been running a vcpkg registry since 2018 at https://github.com/WebKitForWindows/WebKitRequirements for the Windows WebKit port. We’re getting outside contributors including your cohorts at https://playwright.dev/ . So I’m trying to migrate to the canonical registry.
Picked up the libressl port and tried to land the patches that were present here upstream. Was trying to be neighborly by doing that. Maybe in the past it was required 🤷 but it’s not anymore. And the patch will be present in the next release.
Can keep the patch or drop it. Don’t have a strong opinion
There was a problem hiding this comment.
Maybe I didn't pay enough attention...
There might be users which bring custom toolchains that apply /WX.
So patches to resolve issues with /WX are useful.
There was a problem hiding this comment.
Nah, we normally patch out /WX things, and we normally don't expect ports to be warning clean on all platforms, because port consumers generally can't do anything about the results.
If the patch is not needed for the port to build successfully and only affects logs, I agree with @dg0yt's original comment
|
Thanks for the fix! |
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file../vcpkg x-add-version --alland committing the result.