-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wolf-midi] Add new port #42160
[wolf-midi] Add new port #42160
Conversation
ports/cpp-midi/vcpkg.json
Outdated
@@ -0,0 +1,17 @@ | |||
{ | |||
"name": "cpp-midi", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your new port. Could you please change the name of the port? We have difficulty finding your repository using "cpp-midi c++" and "wolfgitpr/cpp-midi" when searching for this port name because it brings up a lot of other library content, which can be confusing for users. I suggest changing the name to wolfgitpr-midi.
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
Thank you for your suggestion. The port and repositories have been renamed to "wolf-midi" and can be found. |
Tested usage successfully by
|
:( I'm sorry to do this to you. I observe that both of these appear to be C++ libraries that might be confused: If I search the first one is the first hit, and the second one is the second hit. However, If we accept this, then the other one would have to become /cc @ericvids |
@BillyONeal, I do not agree with your request for the following reasons:
|
@ericvids The reason we do that is we want someone who does "vcpkg install Xxx" to not be "surprised" in getting a different thing than they thought they were installing. The first priority here is repology, and if we get no hits, plain search engines are the backup. If we can't resolve potential confusion, we default to requiring exactly org-repo, which here would be wolfgitpr-wolf-midi. The rationale is that hopefully the first hit surprises the fewest people. Once we index something under a name, we can't really change what that name means because that would break people. There's no ask to rename someone's project, only an acknowledgement that
Then we need not be concerned about such confusion. Thanks for confirming! |
@ericvids @wolfgitpr Sorry for the confusion, upon confirming the name @JavierMatosD @vicroms @ras0219-msft and I realize that the above discussion could have been interpreted as saying that the name of the project itself needs to change. We are only concerned here with what the name of the port in vcpkg is, please call your project whatever you want :) None of us have a problem with |
The original name 'cpp-midi' is indeed difficult to search for, and I have no objection to the current 'wolf-midi'. Thank you for your review comments. |
Thanks for the new port and sorry for any confusion! |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.