Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wolf-midi] Add new port #42160

Merged
merged 9 commits into from
Nov 22, 2024
Merged

[wolf-midi] Add new port #42160

merged 9 commits into from
Nov 22, 2024

Conversation

wolfgitpr
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@wolfgitpr wolfgitpr marked this pull request as draft November 14, 2024 15:57
@wolfgitpr wolfgitpr marked this pull request as ready for review November 14, 2024 16:57
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 15, 2024
@@ -0,0 +1,17 @@
{
"name": "cpp-midi",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your new port. Could you please change the name of the port? We have difficulty finding your repository using "cpp-midi c++" and "wolfgitpr/cpp-midi" when searching for this port name because it brings up a lot of other library content, which can be confusing for users. I suggest changing the name to wolfgitpr-midi.

@JonLiu1993 JonLiu1993 marked this pull request as draft November 15, 2024 07:04
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@wolfgitpr
Copy link
Contributor Author

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Thank you for your suggestion. The port and repositories have been renamed to "wolf-midi" and can be found.

@wolfgitpr wolfgitpr marked this pull request as ready for review November 15, 2024 10:28
@wolfgitpr wolfgitpr changed the title [cpp-midi] Add new port [wolf-midi] Add new port Nov 15, 2024
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Nov 18, 2024
@JonLiu1993
Copy link
Member

Tested usage successfully by wolf-midi:x64-windows:

wolf-midi provides CMake targets:

  find_package(wolf-midi CONFIG REQUIRED)
  target_link_libraries(main PRIVATE wolf-midi::wolf-midi)

@BillyONeal
Copy link
Member

:( I'm sorry to do this to you. I observe that both of these appear to be C++ libraries that might be confused:

If I search the first one is the first hit, and the second one is the second hit. However,
wolf-midi is very close to our 'autoapprove gitorg-repo' form, so I'm going to confirm with other maintainers before asking you to change anything.

If we accept this, then the other one would have to become ericvids-wolfmidi. On the other hand, that one looks like it might be an 'application' and thus not something we would normally index in the first place...

/cc @ericvids

@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:reviewed Pull Request changes follow basic guidelines labels Nov 19, 2024
@BillyONeal
Copy link
Member

Screenshot_20241118_220158_Arknights.jpg

Packaging in progress....

@ericvids
Copy link

:( I'm sorry to do this to you. I observe that both of these appear to be C++ libraries that might be confused:

If I search the first one is the first hit, and the second one is the second hit. However, wolf-midi is very close to our 'autoapprove gitorg-repo' form, so I'm going to confirm with other maintainers before asking you to change anything.

If we accept this, then the other one would have to become ericvids-wolfmidi. On the other hand, that one looks like it might be an 'application' and thus not something we would normally index in the first place...

/cc @ericvids

@BillyONeal, I do not agree with your request for the following reasons:

  1. My wolfmidi project is NOT a C++ library, it is a mod for the game Wolfenstein 3-D and is irrelevant to your project.
  2. "Searching the first one is the first hit" is a contentious reason to change another project's name. My project has been active since 2021 and is already referenced in build automation scripts in other game-preservation community projects outside of github. The wolf-midi repository is only created this month. Conversely, if you do a Google or Bing search for "wolfmidi", it's my project that comes up, and not wolf-midi.

@BillyONeal
Copy link
Member

BillyONeal commented Nov 19, 2024

"Searching the first one is the first hit" is a contentious reason to change another project's name.

@ericvids The reason we do that is we want someone who does "vcpkg install Xxx" to not be "surprised" in getting a different thing than they thought they were installing. The first priority here is repology, and if we get no hits, plain search engines are the backup. If we can't resolve potential confusion, we default to requiring exactly org-repo, which here would be wolfgitpr-wolf-midi.

The rationale is that hopefully the first hit surprises the fewest people. Once we index something under a name, we can't really change what that name means because that would break people.

There's no ask to rename someone's project, only an acknowledgement that vcpkg install thing can only have one meaning.

My wolfmidi project is NOT a C++ library, it is a mod for the game Wolfenstein 3-D and is irrelevant to your project.

Then we need not be concerned about such confusion. Thanks for confirming!

@BillyONeal
Copy link
Member

@ericvids @wolfgitpr Sorry for the confusion, upon confirming the name @JavierMatosD @vicroms @ras0219-msft and I realize that the above discussion could have been interpreted as saying that the name of the project itself needs to change. We are only concerned here with what the name of the port in vcpkg is, please call your project whatever you want :)

None of us have a problem with wolf-midi here. @wolfgitpr Given the confusion above, did you want to change the name of your project back to something else or are you happy with how this is?

@BillyONeal BillyONeal removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Nov 21, 2024
@BillyONeal BillyONeal added the info:reviewed Pull Request changes follow basic guidelines label Nov 21, 2024
@wolfgitpr
Copy link
Contributor Author

@ericvids @wolfgitpr Sorry for the confusion, upon confirming the name @JavierMatosD @vicroms @ras0219-msft and I realize that the above discussion could have been interpreted as saying that the name of the project itself needs to change. We are only concerned here with what the name of the port in vcpkg is, please call your project whatever you want :)

None of us have a problem with wolf-midi here. @wolfgitpr Given the confusion above, did you want to change the name of your project back to something else or are you happy with how this is?

The original name 'cpp-midi' is indeed difficult to search for, and I have no objection to the current 'wolf-midi'. Thank you for your review comments.

@BillyONeal BillyONeal merged commit 44204b9 into microsoft:master Nov 22, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the new port and sorry for any confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants