Minor self CR feedback.

include/vcpkg/base/diagnostics.h

@@ -193,7 +193,6 @@ namespace vcpkg
     }
 
     // If Ty is a std::unique_ptr<U>, typename AdaptContextDetectUniquePtr<Ty>::type is the type necessary to return
-    // and fwd is the type necessary to move if necessary. Otherwise, there are no members ::type or ::fwd
     template<class Ty>
     struct AdaptContextDetectUniquePtr
     {

include/vcpkg/base/fwd/parse.h

@@ -12,6 +12,5 @@ namespace vcpkg
     };
 
     struct ParseMessage;
-    struct ParseMessages;
     struct ParserBase;
 }

include/vcpkg/base/parse.h

@@ -28,15 +28,6 @@ namespace vcpkg
         LocalizedString format(StringView origin, MessageKind kind) const;
     };
 
-    struct ParseMessages
-    {
-        Optional<LocalizedString> error;
-        std::vector<ParseMessage> warnings;
-
-        void exit_if_errors_or_warnings(StringView origin) const;
-        bool good() const { return !error && warnings.empty(); }
-    };
-
     struct ParserBase
     {
         ParserBase(DiagnosticContext& context, StringView text, StringView origin, TextRowCol init_rowcol = {1, 1});

src/vcpkg-test/ci-baseline.cpp

@@ -203,7 +203,7 @@ bill-made-up-another-skip:x64-linux=skip)"; // note no trailing newline
         }
         else
         {
-            FAIL();
+            FAIL(context.to_string());
         }
     }
 
@@ -219,7 +219,7 @@ bill-made-up-another-skip:x64-linux=skip)"; // note no trailing newline
         }
         else
         {
-            FAIL();
+            FAIL(context.to_string());
         }
     }
 

src/vcpkg/base/diagnostics.cpp

@@ -10,9 +10,7 @@ namespace
 {
     static constexpr StringLiteral ColonSpace{": "};
 
-    void append_file_prefix(std::string& target,
-                            const Optional<std::string>& maybe_origin,
-                            const TextRowCol& position)
+    void append_file_prefix(std::string& target, const Optional<std::string>& maybe_origin, const TextRowCol& position)
     {
         // file:line:col: kind: message
         if (auto origin = maybe_origin.get())

src/vcpkg/base/parse.cpp

@@ -72,24 +72,6 @@ namespace vcpkg
         return res;
     }
 
-    void ParseMessages::exit_if_errors_or_warnings(StringView origin) const
-    {
-        for (const auto& warning : warnings)
-        {
-            msg::println(warning.format(origin, MessageKind::Warning));
-        }
-
-        if (auto e = error.get())
-        {
-            Checks::msg_exit_with_message(VCPKG_LINE_INFO, *e);
-        }
-
-        if (!warnings.empty())
-        {
-            Checks::msg_exit_with_error(VCPKG_LINE_INFO, msgWarningsTreatedAsErrors);
-        }
-    }
-
     ParserBase::ParserBase(DiagnosticContext& context, StringView text, StringView origin, TextRowCol init_rowcol)
         : m_it(text.begin(), text.end())
         , m_start_of_line(m_it)