add a cache for parameters/responses/operations #6030
Conversation
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| @@ -184,7 +184,6 @@ export function createModel(sdkContext: CSharpEmitterContext): CodeModel { | |||
| Type: parameterType, | |||
| Location: RequestLocation.Uri, | |||
| IsApiVersion: parameter.isApiVersionParam, | |||
| IsResourceParameter: false, | |||
There was a problem hiding this comment.
I removed this parameter because in everywhere of our emitter, we are assigning false to this property, and in all the places in MGC.
In autorest.csharp, the only chance that this parameter is assigned to true is in the converter that we convert from swagger, when the parameter has a certain x-ms- extension.
Therefore I think we should not maintain it any more.
This property has never been assigned to true in tspCodeModel.json, therefore it is fine that the InputParameter class in autorest.csharp could keep this property, but we no longer need it here.
| @@ -456,7 +456,6 @@ private static IReadOnlyList<ParameterProvider> BuildSpreadParametersForModel(In | |||
| false, | |||
| false, | |||
| false, | |||
| false, | |||
There was a problem hiding this comment.
TODO - this part is not quite correct to do.
We should not be constructing any input types since we are out of the input library construction.
Instead, this part I think we should
- Build the spread model and get its corresponding
ModelProvider. - "Spread" it into parameters from
ModelProviderand directly get its correspondingParameterProvider.
I will create an issue later to track this.
Fixes #6029
Contributes to #5920