introduce IPC between ts part and C# part to report diagnostics and write logs #5917
+248
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
ArcturusZhang
commented
Feb 17, 2025
...ges/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/Providers/ModelProvider.cs
Outdated
Show resolved
Hide resolved
ArcturusZhang
commented
Feb 17, 2025
ArcturusZhang
commented
Feb 18, 2025
ArcturusZhang
force-pushed
the
some-trials-on-jsonrpc
branch
from
9d1b66a to
25cf9b5
Compare
This reverts commit 25cf9b5.
ArcturusZhang
changed the title
|
@JoshLove-msft this should also contribute to this change despite it has merged: #5904 |
ArcturusZhang
requested review from
m-nash,
JoshLove-msft and
jorgerangel-msft
as code owners
| @@ -61,10 +61,6 @@ public static InputEnumType CreateEnumType(ref Utf8JsonReader reader, string? id | |||
| } | |||
|
|
|||
| name = name ?? throw new JsonException("Enum must have name"); | |||
| if (summary is null && doc is null) | |||
| { | |||
| Console.Error.WriteLine($"[Warn]: Enum '{name}' must have either a summary or doc"); | |||
There was a problem hiding this comment.
Did we intend to not replace this?
|
|
||
| public void Debug(string message) | ||
| { | ||
| SendNotification("trace", new |
There was a problem hiding this comment.
nit: use constant for "trace"
| { | ||
| if (targetCrossLanguageDefinitionId != null) | ||
| { | ||
| SendNotification("diagnostic", new |
|
|
||
| private void Dispose(bool disposing) | ||
| { | ||
| if (!_disposedValue) |
| @@ -5,6 +5,7 @@ | |||
| using System.Collections.Generic; | |||
| using System.IO; | |||
| using System.Linq; | |||
| using Microsoft.TypeSpec.Generator.EmitterRpc; | |||
| @@ -30,9 +31,10 @@ public static async Task<int> Main(string[] args) | |||
|
|
|||
| private static async Task<int> Run(CommandLineOptions options, GeneratorRunner runner) | |||
| { | |||
| var emitter = Emitter.Instance; | |||
There was a problem hiding this comment.
Can we not use using?
JoshLove-msft
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5920