Add the ability to show the tab bar in fullscreen #18171
+157
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Task
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9 tasks
carlos-zamora
approved these changes
Nov 13, 2024
No problem at all, I enjoyed doing it 🙂 Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR allows users to enable the tab bar in fullscreen mode.
References and Relevant Issues
This PR is in response to #11130
Detailed Description of the Pull Request / Additional comments
A new setting; "showTabsFullscreen"; has been added which accepts a boolean value. When
true, then the tab bar will remain visible when the terminal app is fullscreen. If the value isfalse(default), then the tab bar is hidden in fullscreen.When the tab bar is visible in fullscreen, the min/max/close controls are hidden to maintain the expected behaviour of a fullscreen app.
Validation Steps Performed
All unit tests are passing.
Manually verified that when the "launchMode" setting is "fullscreen" and the "showTabsFullscreen" setting is
true, the tab bar is visible on launch.Manually verified that changing the setting at runtime causes the tab bar to be shown/hidden immediately (if the terminal is currently fullscreen).
Manually verified that the new "showTabsFullscreen" setting is honoured regardless of whether "showTabsInTitlebar" is set to
trueorfalse.PR Checklist