-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pane context menu #18126
base: main
Are you sure you want to change the base?
Updated pane context menu #18126
Conversation
… swap panes context menu
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
remove added values that fail ckecks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick feedback before I review the rest of this
…changes to all the Resources.resw files that aren't in the en-us dir
Hi @zadjii-msft, All requested changes are addressed and fixed. |
It feels odd that the split pane entries exists twice on the second level. Can you add a "same profile"/"duplicate" entry at the first position of the third level instead? |
…cate pane' entry at the first position of the third level
You're right, it looks better. |
@dmitrykok |
…the other ones, changed from 'Duplicate pane' to 'Duplicate <profile_name>'
@htcfreek yes, it looks better, also changed from "Duplicate pane" to "Duplicate <profile_name>". |
@dmitrykok |
|
little refactoring
Motivation
The motivation is that Windows users are more accustomed to working with GUI Menus using a mouse, unlike Linux users.
Summary of the Pull Request
added split pane with profile or duplicate up/down/left/right context menus as submenu
added swap panes up/down/left/right context menus as submenu
added toggle pane zoom context menu
added close other panes context menu
References :
Type of change :
Split right to Ubuntu profile from main pane:
Split down duplicate:
Split down to CMD profile from Ubuntu pane:
Split right to Fedora profile from Ubuntu pane:
Result window, with swap menus, you also can see "toggle pane zoom" and "close other panes" menus: