Improve appearance of curly underlines #18092
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-Rendering
|
Before 12pt:
After 12pt:
Before 32pt:
After 32pt:
Yay / Nay? We could revert the frequency of the curve, but I'd rather keep the new height calculation. |
|
We should loudly credit ghostty for inspiring us to be better! |
DHowett
reviewed
Oct 21, 2024
DHowett
added
the
Needs-Discussion
carlos-zamora
removed
the
Needs-Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a tweet about ghostty's pretty underlines and then
looked at ours. They looked worse and that's a no-go.
Validation Steps Performed
Checked with all Windows default fonts at huge and tiny sizes each.