Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XTerm's NumLock mode #16686

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

j4james
Copy link
Collaborator

@j4james j4james commented Feb 8, 2024

Summary of the Pull Request

NumLock mode provides a way to alter the behavior of the numeric keypad,
switching between the standard DEC interpretation of DECKPAM, and a
kind of Linux-compatible mode, where DECKPAM only applies if NumLock
is off. Even then it only applies to the non-digit keys, since the digit
keys are interpreted as cursor keys when NumLock is off.

References and Relevant Issues

#16506, #16511, #16654, #16675

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

@j4james
Copy link
Collaborator Author

j4james commented Feb 8, 2024

I don't particularly like this as a concept, and would prefer a simple setting that could disable DECKPAM, but I thought it worth sharing the code in case anyone else thinks it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant