Code

Move Pane to Tab (GH7075)#10780

Code

Merged

24 commits merged intomicrosoft:mainmicrosoft/terminal:mainfrom Rosefield:feature/gh7075-move-pane-to-tabRosefield/terminal:feature/gh7075-move-pane-to-tabCopy head branch name to clipboardAug 12, 2021

+805-218

Commits

Commits on Jul 20, 2021

• first very-much-not-working pass. Need to figure out how to manage all of the vestigial event handlers when we switch which tab owns a pane.

  Rosefield

  committed
  0fb4b38

  Copy full SHA for 0fb4b38

Commits on Jul 24, 2021

• GH7075 Move Pane to Tab

  Show description for 4adfdee
  Rosefield

  committed
  4adfdee

  Copy full SHA for 4adfdee

Commits on Jul 25, 2021

• Remove control event handlers when pane is detached. Make sure event handlers are removed when a tab gets closed as well. Try to keep active state updated when detaching

  Rosefield

  committed
  e33b7aa

  Copy full SHA for e33b7aa

• Appease the spelling bot

  Rosefield

  committed
  64346fb

  Copy full SHA for 64346fb

• Flesh out comments on new methods. run code formatter

  Rosefield

  committed
  d66d02e

  Copy full SHA for d66d02e

• Fix typos

  Rosefield

  committed
  b8e95e3

  Copy full SHA for b8e95e3

Commits on Jul 29, 2021

• Anticipate some code review refactoring. Make sure that we clean up extra closed handlers if we are moving the root element from a tab. Make sure that we preserve the ids when we attach a child fro…

  Show description for 3bb24b2
  Rosefield

  committed
  3bb24b2

  Copy full SHA for 3bb24b2

• Fix duplicated comment. Only say we handled an action if we actually moved a pane

  Rosefield

  committed
  4077160

  Copy full SHA for 4077160

Commits on Aug 1, 2021

• box the event token so that we can pass a reference to it to the event handler.

  Rosefield

  committed
  a7d7aec

  Copy full SHA for a7d7aec

• Merge remote-tracking branch 'origin/main' into feature/gh7075-move-pane-to-tab

  Show description for e7a9d21
  Rosefield

  committed
  e7a9d21

  Copy full SHA for e7a9d21

Commits on Aug 2, 2021

• Merge remote-tracking branch 'origin/main' into feature/gh7075-move-pane-to-tab

  Show description for eea166c
  Rosefield

  committed
  eea166c

  Copy full SHA for eea166c

• Fix bug where border is lost when child is closed. Make it explicit what kind of split is being made when a pane is attached (so that in the future it doesnt have to always be an automatic split)

  Rosefield

  committed
  abe6a2b

  Copy full SHA for abe6a2b

• spelling

  Rosefield

  committed
  530f658

  Copy full SHA for 530f658

Commits on Aug 4, 2021

• Add action to keybindings in schema

  Rosefield

  committed
  d1ed59c

  Copy full SHA for d1ed59c

• Make separate DetachRoot function so that logic can be used separately (e.g. make tab into pane). Make Pane::DetachPane take a pointer to a pane so that any pane can be detached instead of just one…

  Show description for 23b1ccf
  Rosefield

  committed
  23b1ccf

  Copy full SHA for 23b1ccf

Commits on Aug 5, 2021

• fix comment

  Rosefield

  committed
  ae1a84a

  Copy full SHA for ae1a84a

Commits on Aug 6, 2021

• dont crash if we try to move a pane to a non-terminal tab

  Rosefield

  committed
  ef5089f

  Copy full SHA for ef5089f

Commits on Aug 7, 2021

• Merge remote-tracking branch 'origin/main' into feature/gh7075-move-pane-to-tab

  Show description for 2188f6b
  Rosefield

  committed
  2188f6b

  Copy full SHA for 2188f6b

Commits on Aug 10, 2021

• Rename move-pane -> swap-pane, move-pane-to-tab -> move-pane

  Rosefield

  committed
  c6c9cc1

  Copy full SHA for c6c9cc1

• Merge remote-tracking branch 'origin/main' into feature/gh7075-move-pane-to-tab

  Show description for 012747a
  Rosefield

  committed
  012747a

  Copy full SHA for 012747a

• formatting

  Rosefield

  committed
  4d9e571

  Copy full SHA for 4d9e571

• update tests to be swap-pane as well

  Rosefield

  committed
  e91c69c

  Copy full SHA for e91c69c

Commits on Aug 12, 2021

• Make things that can be const, const

  Rosefield

  committed
  61a3cae

  Copy full SHA for 61a3cae

• Fix crash introduced with last merge; dont try to ask the root pane for state after it has been set to nullptr when closing the tab

  Rosefield

  committed
  1e048e2

  Copy full SHA for 1e048e2