.Net: Remove experimental flag from VectorStore implementations. #9624
+200
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westey-m
commented
Nov 8, 2024
| @@ -21,6 +21,7 @@ namespace Microsoft.SemanticKernel.Diagnostics; | |||
| /// `SEMANTICKERNEL_EXPERIMENTAL_GENAI_ENABLE_OTEL_DIAGNOSTICS` | |||
| /// `SEMANTICKERNEL_EXPERIMENTAL_GENAI_ENABLE_OTEL_DIAGNOSTICS_SENSITIVE` | |||
| /// </summary> | |||
| [Experimental("SKEXP0001")] | |||
There was a problem hiding this comment.
This class is using experimental features and is included in the vector store projects via internal utilities.
Since the projects are not experimental anymore, this class showed up with a warning saying that this is using experimental features in a non-experimental project.
Adding experimental here to remove the warning, without having to suppress the warning at project level.
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
westey-m
commented
Nov 8, 2024
| @@ -12,6 +13,7 @@ namespace Microsoft.SemanticKernel.Connectors.AzureCosmosDBMongoDB; | |||
| /// <summary> | |||
| /// A MongoDB memory record. | |||
| /// </summary> | |||
| [Experimental("SKEXP0020")] | |||
There was a problem hiding this comment.
I'm adding experimental to internal classes as well, since I don't want them accidentally used by us.
dmytrostruk
approved these changes
Nov 8, 2024
| @@ -11,6 +12,7 @@ namespace Microsoft.SemanticKernel.Connectors.AzureAISearch; | |||
| /// Azure AI Search record and index definition. | |||
| /// Note: once defined, index cannot be modified. | |||
| /// </summary> | |||
| [Experimental("SKEXP0020")] | |||
There was a problem hiding this comment.
Do we need to do this for internal classes?
markwallace-microsoft
approved these changes
Nov 8, 2024
|
What does it mean to remove [Experimental] here when the abstractions themselves are still preview? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As part of graduating vector stores we want to remove the experimental flag from the implementations and only keep them on memory store implementations.
#8539
Description
Contribution Checklist