-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Onnx Multi (CPU/GPU/NPU) Target Projects #9437
Open
RogerBarreto
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
RogerBarreto:issues/9056-onnx-cuda-directml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
.Net: Onnx Multi (CPU/GPU/NPU) Target Projects #9437
RogerBarreto
wants to merge
7
commits into
microsoft:main
from
RogerBarreto:issues/9056-onnx-cuda-directml
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
labels
Oct 25, 2024
RogerBarreto
had a problem deploying
to
integration
October 25, 2024 20:20
— with
GitHub Actions
Error
RogerBarreto
had a problem deploying
to
integration
October 25, 2024 20:23
— with
GitHub Actions
Error
RogerBarreto
had a problem deploying
to
integration
October 25, 2024 20:25
— with
GitHub Actions
Error
RogerBarreto
had a problem deploying
to
integration
October 25, 2024 20:26
— with
GitHub Actions
Failure
Aren't the ONNX Runtime GenAI folks working on a solution for this? The virality of having different packages for different targets up the whole stack isn't really tenable. |
RogerBarreto
had a problem deploying
to
integration
October 29, 2024 09:18
— with
GitHub Actions
Failure
RogerBarreto
had a problem deploying
to
integration
October 29, 2024 09:42
— with
GitHub Actions
Failure
RogerBarreto
temporarily deployed
to
integration
October 29, 2024 09:56
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Onnx packages cannot be used together but share the same codebase (abstractions and types), following the same pattern as the dependencies, we have to deploy specific packages intended to be used for the specific platform.
Resolves .Net: Bug: .NET Microsoft.SemanticKernel.Connectors.Onnx missing package release for CUDA and DirectML #9056
Creates new packages specific for each target
Microsoft.SemanticKernel.Connectors.Onnx.Cpu
Microsoft.SemanticKernel.Connectors.Onnx.Gpu
Microsoft.SemanticKernel.Connectors.Onnx.DirectML
Converts
Microsoft.SemanticKernel.Connectors.Onnx
into a meta/proxy package toMicrosoft.SemanticKernel.Connectors.Onnx.Cpu
.