Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Optimize Pinecone GetBatchAsync to retrieve multiple entries with a single request #8289

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ public async IAsyncEnumerable<MemoryRecord> GetBatchAsync(
bool withEmbeddings = false,
[EnumeratorCancellation] CancellationToken cancellationToken = default)
{
await foreach (MemoryRecord? record in this.GetBatchFromNamespaceAsync(collectionName, string.Empty, keys, withEmbeddings, cancellationToken).ConfigureAwait(false))
await foreach (MemoryRecord record in this.GetBatchFromNamespaceAsync(collectionName, string.Empty, keys, withEmbeddings, cancellationToken).ConfigureAwait(false))
{
yield return record;
}
Expand All @@ -285,13 +285,16 @@ public async IAsyncEnumerable<MemoryRecord> GetBatchFromNamespaceAsync(
bool withEmbeddings = false,
[EnumeratorCancellation] CancellationToken cancellationToken = default)
{
foreach (string? key in keys)
await foreach (PineconeDocument? pineconeDocument in this._pineconeClient.FetchVectorsAsync(
indexName,
keys,
indexNamespace,
withEmbeddings,
cancellationToken).ConfigureAwait(false))
{
MemoryRecord? record = await this.GetFromNamespaceAsync(indexName, indexNamespace, key, withEmbeddings, cancellationToken).ConfigureAwait(false);

if (record is not null)
if (pineconeDocument is not null)
{
yield return record;
yield return pineconeDocument.ToMemoryRecord();
}
}
}
Expand Down
Loading