Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove bpftool/bpftrace and add nc/jq to retina-shell image #961

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

wedaly
Copy link
Member

@wedaly wedaly commented Nov 6, 2024

Description

  • bpftool/bpftrace don't work from inside the container, so remove them from the image.
  • nc is useful for testing TCP connectivity, so add it.
  • jq is useful for parsing IMDS output, so add it too.

Related Issue

#910

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

image image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

bpftool/bpftrace don't work from inside the container, so remove them
from the image.

nc is useful for testing TCP connectivity, so add it.
jq is useful for parsing IMDS output, so add it too.

Signed-off-by: Will Daly <[email protected]>
@wedaly wedaly requested a review from a team as a code owner November 6, 2024 21:24
@wedaly wedaly changed the title feat: remove bpftool/bpftrace and add nc to retina-shell image feat: remove bpftool/bpftrace and add nc/jq to retina-shell image Nov 6, 2024
@rbtr rbtr added this pull request to the merge queue Nov 7, 2024
Merged via the queue into microsoft:main with commit 5552182 Nov 7, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants