Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace CGO_ENABLED=0 with //go:build ignore #950

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Nov 5, 2024

  1. Replace CGO_ENABLED=0 with //go:build ignore

    It will soon become necessary to enable CGO in builds in order to use
    the MS Go distribution. Disabling CGO was always somewhat of a hack
    since we didn't need it anyway for eBPF. Now that we do, another
    solution is necessary. This uses the `//go:build ignore` directive to
    exclude all C source files from the Go toolchain. This is necessary even
    within C source files even though these C source files exist within an
    underscore-prefixed directory. Go's behavior here is likely erroneous,
    and an issue has been filed for its repair:
    golang/go#69639
    timraymond committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3d5ba02 View commit details
    Browse the repository at this point in the history