Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ct): add flag to mark ct_entry connection direction is unkown #926

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SRodi
Copy link
Member

@SRodi SRodi commented Nov 1, 2024

Description

  • add new member is_direction_unknown to conntrack_entry struct
  • set is_direction_unknown to true when the SYN packet is not captured

Related Issue

#919

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@SRodi SRodi requested a review from a team as a code owner November 1, 2024 16:32
pkg/plugin/conntrack/_cprog/conntrack.c Outdated Show resolved Hide resolved
pkg/plugin/conntrack/_cprog/conntrack.c Outdated Show resolved Hide resolved
@SRodi SRodi requested a review from timraymond November 5, 2024 16:42
Copy link
Member

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but I also want @nddq to approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants