feat: Retina dataplane debug CLI #740
Conversation
| fmt.Println("eBPF map availability:") | ||
| for _, mt := range eBPFMapList { | ||
| err = features.HaveMapType(mt) | ||
| if err != nil && !errors.Is(err, ebpf.ErrNotSupported) { | ||
| return errors.Wrapf(err, "failed to check for map type %s", mt.String()) | ||
| } | ||
| fmt.Printf("%s: %s\n", mt.String(), isSupported(err)) | ||
| } | ||
|
|
||
| fmt.Println("--------------------------------------------------") | ||
| fmt.Println("eBPF program types availability:") | ||
| for _, pt := range eBPFProgramList { | ||
| err = features.HaveProgramType(pt) | ||
| if err != nil && !errors.Is(err, ebpf.ErrNotSupported) { | ||
| return errors.Wrapf(err, "failed to check for program type %s", pt.String()) | ||
| } | ||
| fmt.Printf("%s: %s\n", pt.String(), isSupported(err)) | ||
| } |
There was a problem hiding this comment.
IMO, it's not important to list all map/prog types. We can just list all maps and programs, and that would be enough information. For specific maps (like conntrack), we may want to print entries, but listing by types is not that helpful.
There was a problem hiding this comment.
this is more so for users to check which maps and programs can be initialize on their host, but yes i do plan to have a command that will list out maps/programs running
| func init() { | ||
| Cmd.AddCommand(featuresCmd) | ||
| Cmd.AddCommand(qdiscCmd) | ||
| } |
There was a problem hiding this comment.
Let's add a status command, showcasing the important one-liners:
- socket setup
- agent running (maybe)
- maps
- programs
- flow rate (?)
- plugins
There was a problem hiding this comment.
you can already get flow rate by exec hubble status on the agent so it might be overkill?
|
an additional scenario might be scraping ourselves on effectively automate this task in our own tsg's |
|
This PR will be closed in 7 days due to inactivity. |
github-actions
bot
added
the
meta/waiting-for-author
|
Pull request closed due to inactivity. |
Description
This PR introduces the skeleton for the dataplane debug CLI, as well as several commands to debug
conntrackRelated Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.