Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust dependency versions (except pyo3, rustc_hash, and miette) #1876

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Aug 22, 2024

This PR updates all of our Rust dependencies to their latest versions, with the exception of:

  • pyo3, which will require some more work as its API has changed-
  • miette, which doesn't seem to support wasm on certain platforms post-v5? Needs more investigation
  • rustc_hash, which had a breaking change in the order of iteration over FxHashMaps.

Note: we apparently iterate over hashmaps in various places, and then do snapshot tests on the results. rustc_hash changed some iteration ordering, so updating this dependency caused some expect tests to need updating. In a perfect world, we'd track down these iterations and make them deterministic. But, the effort/outcome ratio is so low there, since iteration order is deterministic within a single version of rustc_hash, I say we just update the expect tests and move on.

I also removed patch-version pins from our Cargo.toml where they existed, since we usually just specify major.minor.

#1886: issue to track updating pyo3
#1877: issue to track updating rustc_hash

I'm not sure we want to update miette any time soon -- it breaks us in a big way and we are happy with the current version I think. But we should have a discussion about that. So I filed #1887 to track that.

@sezna sezna changed the title Update versions of rust dependencies Bump rust dependency versions (except pyo3) Aug 22, 2024
@sezna sezna changed the title Bump rust dependency versions (except pyo3) Bump rust dependency versions (except pyo3, rustc_hash, and miette) Aug 23, 2024
@sezna sezna marked this pull request as ready for review August 26, 2024 17:31
@sezna sezna added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit b2f7ddd Aug 26, 2024
19 checks passed
@sezna sezna deleted the alex/versions branch August 26, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants