Bump rust dependency versions (except pyo3
, rustc_hash
, and miette
)
#1876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all of our Rust dependencies to their latest versions, with the exception of:
pyo3
, which will require some more work as its API has changed-miette
, which doesn't seem to support wasm on certain platforms post-v5? Needs more investigationrustc_hash
, which had a breaking change in the order of iteration overFxHashMap
s.Note: we apparently iterate over hashmaps in various places, and then do snapshot tests on the results.
rustc_hash
changed some iteration ordering, so updating this dependency caused some expect tests to need updating. In a perfect world, we'd track down these iterations and make them deterministic. But, the effort/outcome ratio is so low there, since iteration order is deterministic within a single version ofrustc_hash
, I say we just update the expect tests and move on.I also removed patch-version pins from our
Cargo.toml
where they existed, since we usually just specify major.minor.#1886: issue to track updating
pyo3
#1877: issue to track updating
rustc_hash
I'm not sure we want to update
miette
any time soon -- it breaks us in a big way and we are happy with the current version I think. But we should have a discussion about that. So I filed #1887 to track that.