Site Preview Enhancements: Clear cache and telemetry logging #1088
+85
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyanshu92
changed the title
| await PreviewSite.launchBrowserAndDevToolsWithinVsCode(this._websiteUrl); | ||
| } | ||
|
|
||
| private static async handleEmptyWebsiteUrl(pacTerminal: PacTerminal, telemetry: ITelemetry): Promise<boolean> { | ||
| private static async clearCache(telemetry: ITelemetry, orgDetails: IOrgDetails): Promise<void> { |
There was a problem hiding this comment.
Is it possible to reuse the implementation done for web?
There was a problem hiding this comment.
The web implementation is tightly coupled to WebExtensionContext and will require lot of refactoring to make it reusable. We can do it in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
PreviewSitefunctionality by adding error handling, cache clearing, and telemetry logging. The changes include updates to constants, imports, and thePreviewSiteclass to support these new features.Error handling and telemetry logging:
src/client/preview-site/Constants.ts: Added new messages for various errors and actions such asORG_DETAILS_ERROR,CLEARING_CACHE,AUTHENTICATING, andUNABLE_TO_CLEAR_CACHE.src/common/services/TelemetryConstants.ts: Added a new telemetry constantVSCODE_EXTENSION_SITE_PREVIEW_ERRORto log site preview errors.src/client/preview-site/PreviewSite.ts: Added telemetry error events and log traces for different error scenarios such as feature not enabled, no folder opened, and initialization errors.Cache clearing functionality:
src/client/preview-site/PreviewSite.ts: Introduced theclearCachemethod to clear the cache using an authenticated request and added progress notifications for cache clearing.