Pin our tracing-core dep due to binary size concerns #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprilik
reviewed
Dec 30, 2024
daprilik
previously approved these changes
Jan 2, 2025
daprilik
approved these changes
Jan 2, 2025
|
That's alright, I thought hard about them while writing them. |
smalis-msft
added a commit
that referenced
this pull request
Jan 7, 2025
I added workspace metadata for openvmm for the first time in #593. This broke xsync, as it was expecting there to be no metadata. Instead, allow it to take arbitrary toml as metadata, then just do nothing with it. This should restore the internal mirror functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make sure we don't end up updating this accidentally.