Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit the subfunction in if cond from inside a block #1115

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justinchuby
Copy link
Collaborator

Trying to fix #1109

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1115 (2ec39c5) into main (4d7ac4d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1115   +/-   ##
=======================================
  Coverage   78.44%   78.44%           
=======================================
  Files         118      118           
  Lines       14954    14954           
  Branches     1586     1586           
=======================================
  Hits        11730    11730           
  Misses       2859     2859           
  Partials      365      365           
Files Coverage Δ
onnxscript/irbuilder.py 76.92% <ø> (ø)

@github-actions
Copy link

Test Results

         18 files  ±       0         18 suites  ±0   1h 24m 7s ⏱️ + 2m 7s
  11 086 tests  - 1 170    8 326 ✔️  - 918      2 723 💤  - 252       37 ±0 
158 748 runs  ±       0  36 434 ✔️ ±    0  120 460 💤 ±    0  1 854 ±0 

For more details on these failures, see this check.

Results for commit 2ec39c5. ± Comparison against base commit 4d7ac4d.

This pull request removes 2317 and adds 1147 tests. Note that renamed tests count towards both.
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0014_test_string_split_empty_string_delimiter
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0015_test_hardmax_one_hot
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0016_test_maxunpool_export_without_output_shape
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0017_test_max_example
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0018_test_layer_normalization_4d_axis_negative_2_expanded_ver18
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0019_test_sequence_map_extract_shapes_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0020_test_hardmax_default_axis
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0021_test_sub_bcast
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0022_test_gridsample_volumetric_bilinear_align_corners_0
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0023_test_ai_onnx_ml_binarizer
…
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0014_test_hardmax_one_hot
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0015_test_maxunpool_export_without_output_shape
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0016_test_max_example
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0017_test_layer_normalization_4d_axis_negative_2_expanded_ver18
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0018_test_sequence_map_extract_shapes_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0019_test_hardmax_default_axis
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0020_test_sub_bcast
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0022_test_concat_2d_axis_1
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0023_test_reduce_prod_keepdims_example
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0024_test_min_float16
…
This pull request removes 441 skipped tests and adds 189 skipped tests. Note that renamed tests count towards both.
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0014_test_string_split_empty_string_delimiter
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0019_test_sequence_map_extract_shapes_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0022_test_gridsample_volumetric_bilinear_align_corners_0
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0023_test_ai_onnx_ml_binarizer
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0027_test_reduce_l1_empty_set_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0030_test_gelu_default_2
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0037_test_castlike_FLOAT_to_FLOAT8E4M3FN_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0048_test_cast_FLOAT16_to_FLOAT8E4M3FNUZ
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0052_test_dequantizelinear_e4m3fn_zero_point
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0054_test_castlike_FLOAT_to_FLOAT8E5M2FNUZ_expanded
…
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0018_test_sequence_map_extract_shapes_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0033_test_castlike_FLOAT_to_FLOAT8E4M3FN_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0044_test_cast_FLOAT16_to_FLOAT8E4M3FNUZ
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0049_test_castlike_FLOAT_to_FLOAT8E5M2FNUZ_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0054_test_center_crop_pad_crop_negative_axes_hwc_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0055_test_castlike_BFLOAT16_to_FLOAT_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0057_test_max_uint16
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0063_test_min_uint8
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0066_test_batchnorm_epsilon
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0068_test_maxunpool_export_with_output_shape
…
This pull request skips 1 and un-skips 1 tests.
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0014_test_constantofshape_int_zeros
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0000_test_constantofshape_float_ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opsets not imported for functions when the op is used in an if branch
1 participant