Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure exporter creates valid python name for opset vars #1051

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

gramalingam
Copy link
Collaborator

The existing exporter creates invalid python identifiers like "onnxscript.atenlib1" when generating variable names for opsets. Change this to create a name like "onnxscript_atenlib1".

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1051 (4a6a399) into main (8af8161) will increase coverage by 0.02%.
The diff coverage is 82.22%.

@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   77.75%   77.78%   +0.02%     
==========================================
  Files         114      114              
  Lines       14489    14517      +28     
  Branches     1549     1554       +5     
==========================================
+ Hits        11266    11292      +26     
- Misses       2857     2858       +1     
- Partials      366      367       +1     
Files Changed Coverage Δ
onnxscript/backend/onnx_export.py 70.12% <79.41%> (+1.61%) ⬆️
onnxscript/backend/onnx_export_test.py 86.04% <90.90%> (+0.09%) ⬆️

📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Test Results

         18 files  ±0         18 suites  ±0   1h 11m 33s ⏱️ - 8m 35s
  10 616 tests +1    7 879 ✔️ +1      2 737 💤 ±0  0 ±0 
150 633 runs  +9  33 263 ✔️ +9  117 370 💤 ±0  0 ±0 

Results for commit 4a6a399. ± Comparison against base commit 8af8161.

♻️ This comment has been updated with latest results.

@gramalingam gramalingam merged commit 5eebc89 into main Sep 7, 2023
31 checks passed
@gramalingam gramalingam deleted the rama/exporter_bug_qualified_domain branch September 7, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants