Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable comprehension simplification in ruff rules #23414

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Enable comprehension simplification in ruff rules #23414

merged 2 commits into from
Jan 17, 2025

Conversation

justinchuby
Copy link
Contributor

@justinchuby justinchuby commented Jan 17, 2025 •
edited
Loading

Enable comprehension simplification rules (C4) for ruff and apply autofix.

@justinchuby justinchuby requested a review from snnn January 17, 2025 06:02
snnn
snnn approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The new code is much simpler

@justinchuby justinchuby merged commit ad312d9 into main Jan 17, 2025
97 of 98 checks passed
@justinchuby justinchuby deleted the justinchu/c4 branch January 17, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snnn snnn snnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinchuby @snnn