Make token_type_ids optional output for HFBertTokenizer op
#583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
October 24, 2023 16:11
sayanshaw24
reviewed
Oct 27, 2023
sayanshaw24
reviewed
Oct 27, 2023
…ttps://github.com/microsoft/onnxruntime-extensions into yguo/optional-output-for-bertokenizer-token-type-id
wenbingl
reviewed
Oct 28, 2023
| @@ -396,7 +396,7 @@ KernelHfBertTokenizer::KernelHfBertTokenizer(const OrtApi& api, const OrtKernelI | |||
| void KernelHfBertTokenizer::Compute(const ortc::Tensor<std::string>& input, | |||
There was a problem hiding this comment.
a side question, why use KernelHfBertTokenizer, instead of KernelBertTokenizer?
There was a problem hiding this comment.
using HFBertTokenizer here as the model I am tryig to add ppp to are mainly from hugging face distilbert-based models.
skottmckay
reviewed
Oct 30, 2023
YUNQIUGUO
deleted the
yguo/optional-output-for-bertokenizer-token-type-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.