fix(declarative-chart): Handle 10^N yMax case for rounded ticks #33870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Feb 19, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Gaps.default.chromium.png | 1 | Changed |
AtishayMsft
reviewed
Feb 19, 2025
| return Math.log10(n) % 1 === 0; | ||
| } | ||
|
|
||
| function roundIfAlmostInteger(num: number): number { |
There was a problem hiding this comment.
Call this handleFloatingPointPrecisionError and add link to this article as comment.
https://docs.python.org/release/2.5.1/tut/node16.html
AtishayMsft
reviewed
Feb 19, 2025
| @@ -256,6 +256,15 @@ function multiFormat(date: Date, locale?: d3TimeLocaleObject, useUTC?: boolean) | |||
| )(date); | |||
| } | |||
|
|
|||
| function isPowerOf10(n: number): boolean { | |||
| return Math.log10(n) % 1 === 0; | |||
There was a problem hiding this comment.
We are already checking that in 'handleFloatingPointPrecisionError' function. Then is it needed here also? Rounded value will only come here.
AtishayMsft
reviewed
Feb 19, 2025
| @@ -391,6 +391,11 @@ describe('prepareDatapoints for rounded tick value cases', () => { | |||
| const result = utils.prepareDatapoints(589030.78, -234.45, 4, false, true); | |||
| matchResult(result); | |||
| }); | |||
|
|
|||
| it('should return an array with rounded data points when yMax is almost power of 10', () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Related Issue(s)