Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish stable version of charts V9 package. #33858

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Publish stable version of charts V9 package. #33858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ac78ad
update v9 charts package to stable version
Anush2303 Feb 18, 2025
b9a36e3
Add change file
Anush2303 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ packages/azure-themes @Jacqueline-ms
packages/react-conformance @microsoft/fluentui-react-build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report

Accordion 1 screenshots
Image Name Diff(in Pixels) Image Type
Accordion. - Dark Mode.normal.chromium.png 2660 Changed
Button 3 screenshots
Image Name Diff(in Pixels) Image Type
Button. - Dark Mode.hover.chromium_2.png 1109 Changed
Button. - Dark Mode.default.chromium_1.png 961 Changed
Button. - Dark Mode.pressed.chromium_3.png 633 Changed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

Callout 2 screenshots
Image Name Diff(in Pixels) Image Type
Callout.No callout width specified.default.chromium.png 2319 Changed
Callout.Top auto edge.default.chromium.png 2307 Changed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.badgeMask - RTL.normal.chromium.png 5 Changed
Slider Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Slider Converged.Customized Slider.chromium.png 443 Changed

packages/charts/chart-web-components @microsoft/charting-team
packages/charts/react-charting @microsoft/charting-team
packages/charts/react-charts-preview/library @microsoft/charting-team
packages/charts/react-charts-preview/stories @microsoft/charting-team
packages/charts/react-charts/library @microsoft/charting-team
packages/charts/react-charts/stories @microsoft/charting-team
packages/date-time-utilities @microsoft/cxe-red
packages/eslint-plugin @microsoft/fluentui-react-build
packages/foundation-legacy @microsoft/cxe-red @khmakoto
Expand Down
2 changes: 1 addition & 1 deletion apps/chart-docsite/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const config: StorybookConfig = {
'../src/**/*.mdx',
'../src/**/index.stories.@(js|jsx|ts|tsx)',
// packages stories
'../../../packages/charts/react-charts-preview/stories/**/index.stories.@(js|jsx|ts|tsx)',
'../../../packages/charts/react-charts/stories/**/index.stories.@(js|jsx|ts|tsx)',
],
};

Expand Down
2 changes: 1 addition & 1 deletion apps/chart-docsite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@fluentui/scripts-tasks": "*"
},
"dependencies": {
"@fluentui/react-charts-preview": "*",
"@fluentui/react-charts": "*",
"@fluentui/react-storybook-addon": "*",
"@fluentui/react-storybook-addon-export-to-sandbox": "*",
"react": "17.0.2",
Expand Down
4 changes: 2 additions & 2 deletions apps/chart-docsite/src/Introduction.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ To get started with the charts package in your project:
1. Install the desired package using `npm` or `yarn`:

```
npm install @fluentui/react-charts-preview
npm install @fluentui/react-charts
```

or

```
yarn add @fluentui/react-charts-preview
yarn add @fluentui/react-charts
```

2. Import and use the charts in your React application.
Expand Down
2 changes: 1 addition & 1 deletion apps/public-docsite-v9/.storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ module.exports = /** @type {Omit<import('../../../.storybook/main'), 'typescript
// Workaround to enable docsite using PR workflow till master workflow is enabled
url: 'https://fluentuipr.z22.web.core.windows.net/pull/33270/chart-docsite/storybook',
expanded: false,
sourceUrl: 'https://github.com/microsoft/fluentui/charts/react-charts-preview',
sourceUrl: 'https://github.com/microsoft/fluentui/charts/react-charts',
},
},
});
2 changes: 1 addition & 1 deletion apps/vr-tests-react-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@fluentui/react-button": "*",
"@fluentui/react-calendar-compat": "*",
"@fluentui/react-card": "*",
"@fluentui/react-charts-preview": "*",
"@fluentui/react-charts": "*",
"@fluentui/react-checkbox": "*",
"@fluentui/react-color-picker-preview": "*",
"@fluentui/react-combobox": "*",
Expand Down
2 changes: 1 addition & 1 deletion apps/vr-tests-react-components/src/stories/Charts/DonutChart.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import type { Meta } from '@storybook/react';
import { DARK_MODE, getStoryVariant, RTL, TestWrapperDecorator } from '../../utilities';
import { Steps, StoryWright } from 'storywright';
import { ChartProps, ChartDataPoint, DonutChart } from '@fluentui/react-charts-preview';
import { ChartProps, ChartDataPoint, DonutChart } from '@fluentui/react-charts';

export default {
title: 'Charts/DonutChart',
Expand Down
2 changes: 1 addition & 1 deletion apps/vr-tests-react-components/src/stories/Charts/HorizontalBarChart.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import type { Meta } from '@storybook/react';
import { DARK_MODE, getStoryVariant, RTL, TestWrapperDecorator } from '../../utilities';
import { Steps, StoryWright } from 'storywright';
import { ChartProps, HorizontalBarChart, HorizontalBarChartVariant } from '@fluentui/react-charts-preview';
import { ChartProps, HorizontalBarChart, HorizontalBarChartVariant } from '@fluentui/react-charts';

export default {
title: 'Charts/HorizontalBarChart',
Expand Down
2 changes: 1 addition & 1 deletion apps/vr-tests-react-components/src/stories/Charts/Legend.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import type { Meta } from '@storybook/react';
import { DARK_MODE, getStoryVariant, RTL, TestWrapperDecorator } from '../../utilities';
import { Steps, StoryWright } from 'storywright';
import { Legend, Legends } from '@fluentui/react-charts-preview';
import { Legend, Legends } from '@fluentui/react-charts';

export default {
title: 'Charts/Legend',
Expand Down
8 changes: 1 addition & 7 deletions apps/vr-tests-react-components/src/stories/Charts/LineChart.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,7 @@ import * as React from 'react';
import type { Meta } from '@storybook/react';
import { Steps, StoryWright } from 'storywright';
import { DARK_MODE, getStoryVariant, RTL, TestWrapperDecorator } from '../../utilities';
import {
LineChartPoints,
LineChart,
ChartProps,
DataVizPalette,
CustomizedCalloutData,
} from '@fluentui/react-charts-preview';
import { LineChartPoints, LineChart, ChartProps, DataVizPalette, CustomizedCalloutData } from '@fluentui/react-charts';

export default {
title: 'Charts/LineChart',
Expand Down
2 changes: 1 addition & 1 deletion apps/vr-tests-react-components/src/stories/Charts/SparklineChart.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import type { Meta } from '@storybook/react';
import { DARK_MODE, getStoryVariant, RTL, TestWrapperDecorator } from '../../utilities';
import { Steps, StoryWright } from 'storywright';
import { ChartProps, Sparkline } from '@fluentui/react-charts-preview';
import { ChartProps, Sparkline } from '@fluentui/react-charts';

export default {
title: 'Charts/SparkLineChart',
Expand Down
2 changes: 1 addition & 1 deletion apps/vr-tests-react-components/src/stories/Charts/VerticalBarChart.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import type { Meta } from '@storybook/react';
import { DARK_MODE, getStoryVariant, RTL, TestWrapperDecorator } from '../../utilities';
import { Steps, StoryWright } from 'storywright';
import { LineChartLineOptions, VerticalBarChartDataPoint, VerticalBarChart } from '@fluentui/react-charts-preview';
import { LineChartLineOptions, VerticalBarChartDataPoint, VerticalBarChart } from '@fluentui/react-charts';

export default {
title: 'Charts/VerticalBarChart',
Expand Down
7 changes: 7 additions & 0 deletions change/@fluentui-react-charts-21eeef06-4528-4472-9d80-6ee7d0ec5d3a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "publish stable version of charts v9 package",
"packageName": "@fluentui/react-charts",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion change/@fluentui-react-charts-preview-cbb156e6-46e4-46d2-9772-6ba9c4778669.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "none",
"comment": "chore: add new 'charting' domain tag",
"packageName": "@fluentui/react-charts-preview",
"packageName": "@fluentui/react-charts",
"email": "[email protected]",
"dependentChangeType": "none"
}
17 changes: 0 additions & 17 deletions packages/charts/react-charts-preview/stories/README.md
View file
Open in desktop

This file was deleted.

0 ...eact-charts-preview/library/.babelrc.json → ...charts/react-charts/library/.babelrc.json
View file
Open in desktop
File renamed without changes.
0 ...act-charts-preview/library/.eslintrc.json → ...harts/react-charts/library/.eslintrc.json
View file
Open in desktop
File renamed without changes.
0 ...harts/react-charts-preview/library/.swcrc → packages/charts/react-charts/library/.swcrc
View file
Open in desktop
File renamed without changes.
Loading