fix(Carousel): autoplay does not trigger live region announcements #33832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smhigley
commented
Feb 12, 2025
| @@ -81,16 +86,17 @@ export function useCarousel_unstable(props: CarouselProps, ref: React.Ref<HTMLDi | |||
|
|
|||
| const { announce } = useAnnounce(); | |||
|
|
|||
| const updateAnnouncement = useEventCallback(() => { | |||
| const updateAnnouncement = useEventCallback((newIndex: number) => { | |||
There was a problem hiding this comment.
I updated this to take an index directly, since activeIndex isn't updated to the new value when updateAnnouncement is called
smhigley
force-pushed
the
carousel-auto-announce
branch
from
0b069d6 to
f956851
Compare
|
Pull request demo site: URL |
📊 Bundle size report
Unchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When autoplay is enabled, it fires a live region message on every automatic slide change, which ends up being pretty disruptive when trying to browse the page with a screen reader.
New Behavior
Live region announcements fire for all non-automatic slide changes, but not for autoplay.
Related Issue(s)
(Found this when working on a different carousel bug that ended up being unrelated)