Change border radii #33823
Open
Change border radii #33823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
fabricteam
reviewed
Feb 11, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report
Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar.Shape.chromium.png | 3 | Changed |
Badge 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Badge.Shape Dark Mode.chromium.png | 10 | Changed |
| Badge.Shape.chromium.png | 28 | Changed |
Button 32 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Button.Large With Icon.chromium.png | 16 | Changed |
| Button.Medium Icon Only.chromium.png | 9 | Changed |
| Button.Medium With Icon.chromium.png | 9 | Changed |
| Button.Large.chromium.png | 16 | Changed |
| Button.Medium With Icon Dark Mode.chromium.png | 13 | Changed |
| Button.Medium.chromium.png | 9 | Changed |
| Button.Large With Icon Dark Mode.chromium.png | 24 | Changed |
| Button.Large Icon Only Dark Mode.chromium.png | 24 | Changed |
| Button.Medium Icon Only Dark Mode.chromium.png | 13 | Changed |
| Button.Default.chromium.png | 9 | Changed |
| Button.Large With Icon RTL.chromium.png | 16 | Changed |
| Button.Medium With Icon RTL.chromium.png | 9 | Changed |
| Button.Large Icon Only.chromium.png | 16 | Changed |
| Button.Outline Disabled.chromium.png | 5 | Changed |
| Button.Outline Dark Mode.chromium.png | 14 | Changed |
| Button.Outline Disabled Focusable Dark Mode.chromium.png | 5 | Changed |
| Button.Outline Disabled Dark Mode.chromium.png | 5 | Changed |
| Button.Outline.chromium.png | 8 | Changed |
| Button.Outline Disabled Focusable.chromium.png | 5 | Changed |
| Button.Primary Disabled Focusable Dark Mode.chromium.png | 2 | Changed |
| Button.Primary.chromium.png | 28 | Changed |
| Button.Primary Dark Mode.chromium.png | 10 | Changed |
| Button.Primary Disabled Dark Mode.chromium.png | 2 | Changed |
| Button.Rounded.chromium.png | 9 | Changed |
| Button.Small Icon Only.chromium.png | 7 | Changed |
| Button.Small With Icon.chromium.png | 7 | Changed |
| Button.Small Icon Only Dark Mode.chromium.png | 42 | Changed |
| Button.Small With Icon Dark Mode.chromium.png | 305 | Changed |
| Button.With Long Text.chromium.png | 9 | Changed |
| Button.Small With Icon RTL.chromium.png | 6 | Changed |
| Button.Small.chromium.png | 7 | Changed |
| Button.With Long Text RTL.chromium.png | 9 | Changed |
Checkbox 11 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Checkbox.Checked.chromium.png | 20 | Changed |
| Checkbox.Default Dark Mode.chromium.png | 23 | Changed |
| Checkbox.Checked Dark Mode.chromium.png | 14 | Changed |
| Checkbox.Default RTL.chromium.png | 24 | Changed |
| Checkbox.Disabled Dark Mode.chromium.png | 5 | Changed |
| Checkbox.Disabled Checked.chromium.png | 2 | Changed |
| Checkbox.Default.chromium.png | 25 | Changed |
| Checkbox.Disabled Checked Dark Mode.chromium.png | 5 | Changed |
| Checkbox.Indeterminate.chromium.png | 25 | Changed |
| Checkbox.Disabled.chromium.png | 2 | Changed |
| Checkbox.Indeterminate Dark Mode.chromium.png | 23 | Changed |
MenuList 13 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MenuList.Checkbox RTL.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons RTL.chromium.png | 4 | Changed |
| MenuList.Checkbox With Icons.chromium.png | 4 | Changed |
| MenuList.Checkbox.chromium.png | 4 | Changed |
| MenuList.Default.chromium.png | 4 | Changed |
| MenuList.Radio With Icons.chromium.png | 4 | Changed |
| MenuList.Radio RTL.chromium.png | 4 | Changed |
| MenuList.Radio With Icons RTL.chromium.png | 4 | Changed |
| MenuList.Default RTL.chromium.png | 4 | Changed |
| MenuList.With Submenu.chromium.png | 4 | Changed |
| MenuList.Radio.chromium.png | 4 | Changed |
| MenuList.With Icons.chromium.png | 4 | Changed |
| MenuList.With Submenu RLT.chromium.png | 4 | Changed |
TextInput 26 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| TextInput.Appearance Filled Lighter.chromium.png | 38 | Changed |
| TextInput.Appearance Filled Darker Dark Mode.chromium.png | 38 | Changed |
| TextInput.Appearance Filled Lighter Dark Mode.chromium.png | 36 | Changed |
| TextInput.Appearance Outline.chromium.png | 19 | Changed |
| TextInput.Appearance Filled Darker.chromium.png | 36 | Changed |
| TextInput.Appearance Outline Dark Mode.chromium.png | 23 | Changed |
| TextInput.Content End Dark Mode.chromium.png | 23 | Changed |
| TextInput.Content End.chromium.png | 19 | Changed |
| TextInput.Content End RTL.chromium.png | 16 | Changed |
| TextInput.Content Start Dark Mode.chromium.png | 23 | Changed |
| TextInput.Content Start End Dark Mode.chromium.png | 23 | Changed |
| TextInput.Content Start RTL.chromium.png | 16 | Changed |
| TextInput.Content Start End RTL.chromium.png | 16 | Changed |
| TextInput.Content Start End.chromium.png | 19 | Changed |
| TextInput.Content Start.chromium.png | 19 | Changed |
| TextInput.Default.chromium.png | 19 | Changed |
| TextInput.Disabled.chromium.png | 5 | Changed |
| TextInput.Inline.chromium.png | 16 | Changed |
| TextInput.Placeholder Dark Mode.chromium.png | 23 | Changed |
| TextInput.Disabled Dark Mode.chromium.png | 5 | Changed |
| TextInput.Placeholder.chromium.png | 19 | Changed |
| TextInput.Size Medium.chromium.png | 19 | Changed |
| TextInput.Required Dark Mode.chromium.png | 23 | Changed |
| TextInput.Size Small.chromium.png | 19 | Changed |
| TextInput.Required.chromium.png | 19 | Changed |
| TextInput.Size Large.chromium.png | 19 | Changed |
fabricteam
reviewed
Feb 11, 2025
|
Checkboxes are looking a little tight: 
|
|
Underlines on the focussed inputs also look like they need some touching up: But this change seems to fix it: After: |
|
Select has a unique underline: |
|
Chubby carrot in info label:
|
|
Similair Carrot issue in teaching popover:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test to see how things change with updated radii