Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-motion): apply initial styles consistently #33810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Feb 10, 2025

Fixes #33812.


  • Fixes issues with styles on initial mount
  • Updates unit tests

Copy link

github-actions bot commented Feb 10, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
107.018 kB
32.834 kB
106.976 kB
32.812 kB
-42 B
-22 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
224.582 kB
64.913 kB
224.54 kB
64.89 kB
-42 B
-23 B
react-components
react-components: entire library
1.17 MB
292.991 kB
1.17 MB
292.973 kB
-42 B
-18 B
react-dialog
Dialog (including children components)
100.513 kB
30.131 kB
100.471 kB
30.114 kB
-42 B
-17 B
react-motion
@fluentui/react-motion - createPresenceComponent()
5.231 kB
2.296 kB
5.189 kB
2.274 kB
-42 B
-22 B
react-toast
Toast (including Toaster)
101.309 kB
30.521 kB
101.267 kB
30.5 kB
-42 B
-21 B
react-tree
FlatTree
147.793 kB
42.393 kB
147.751 kB
42.373 kB
-42 B
-20 B
react-tree
PersonaFlatTree
148.538 kB
42.536 kB
148.496 kB
42.517 kB
-42 B
-19 B
react-tree
PersonaTree
144.749 kB
41.391 kB
144.707 kB
41.371 kB
-42 B
-20 B
react-tree
Tree
144.01 kB
41.265 kB
143.968 kB
41.245 kB
-42 B
-20 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.638 kB
20.24 kB
react-components
react-components: FluentProvider & webLightTheme
44.473 kB
14.597 kB
react-message-bar
MessageBar (all components)
24.882 kB
9.269 kB
react-motion
@fluentui/react-motion - createMotionComponent()
4.506 kB
1.967 kB
react-motion
@fluentui/react-motion - PresenceGroup
1.714 kB
819 B
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
108.551 kB
36.094 kB
🤖 This report was generated against dc55108e1ff4d9e1b425c2272341e046d140be95

Copy link

Pull request demo site: URL

@@ -0,0 +1,7 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.Badge Mask RTL.chromium.png 2 Changed
Avatar Converged.badgeMask.chromium.png 5 Changed
Drawer 1 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.Full Overlay Dark Mode.chromium.png 988 Changed

@layershifter layershifter marked this pull request as ready for review February 10, 2025 11:14
@layershifter layershifter requested a review from a team as a code owner February 10, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Motion does not apply styles consistently
3 participants