feat(eslint-plugin): add browser compatibility plugin #33786
+91
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokirpa
commented
Feb 5, 2025
dmytrokirpa
force-pushed
the
feat/add-eslint-plugin-compat
branch
from
8753796 to
7ad07cc
Compare
fabricteam
reviewed
Feb 5, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
react-charting-HeatMapChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-HeatMapChart.Basic.default.chromium.png | 376 | Changed |
react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-LineChart.Events.default.chromium.png | 2 | Changed |
📊 Bundle size report
Unchanged fixtures
|
🕵 FluentUIV0 No visual regressions between this PR and main |
|
Pull request demo site: URL |
Hotell
reviewed
Feb 6, 2025
# Conflicts: # yarn.lock
dmytrokirpa
force-pushed
the
feat/add-eslint-plugin-compat
branch
from
d4a3131 to
e7e3c9f
Compare
fabricteam
reviewed
Feb 13, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report
Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Badge. - Dark Mode.normal.chromium_1.png | 511 | Changed |
Checkbox 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Checkbox. - Dark Mode.normal.chromium.png | 37 | Changed |
Divider 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Divider. - RTL.normal.chromium_1.png | 103 | Changed |
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
reviewed
Feb 17, 2025
| @@ -24,5 +29,28 @@ module.exports = { | |||
| '@rnx-kit/no-export-all': ['error', { expand: 'all' }], | |||
| }, | |||
| }, | |||
| { | |||
| files: [...testFiles, ...storyFiles], | |||
There was a problem hiding this comment.
hmm adding it to overrides would be easier for future migration to flat configs and also would make it more readable as exclude + include would be part of same config
if we add it to existing
files: '**/src/**/*.{ts,tsx,js}',override
{
files: '**/src/**/*.{ts,tsx,js}',
excludedFiles: [...testFiles],
extends: ['plugin:compat/recommended'],
plugins: ['compat'],
settings: {
// Browser matrix support - https://react.fluentui.dev/?path=/docs/concepts-developer-browser-support-matrix--docs#partial-browser-support-matrix
targets: [
// Desktop browsers
'edge >= 79',
'firefox >= 69',
'chrome >= 79',
'safari >= 13.1',
'opera >= 64',
'not ie <= 11',
// Mobile browsers
'ios_saf >= 13.4',
'android >= 79',
'samsung >= 14',
'not op_mini all',
],
},
WDYT ?
Hotell
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
No browser compatibility linter rules were available.
New Behavior
Added
eslint-plugin-compatto ensure browser compatibility according to the current browser support matrixRelated Issue(s)