feat(react-charting): Heatmap text color based on Contrast Ratio #33659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Jan 15, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
Keytip 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Keytip.Offset.chromium.png | 121 | Changed |
react-charting-AreaChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-AreaChart.Basic RTL.chromium.png | 841 | Changed |
| react-charting-AreaChart.Basic Dark Mode.chromium.png | 847 | Changed |
| react-charting-AreaChart.Basic.chromium.png | 847 | Changed |
react-charting-DonutChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-DonutChart.Basic.chromium.png | 634 | Changed |
| react-charting-DonutChart.Basic RTL.chromium.png | 642 | Changed |
| react-charting-DonutChart.Basic Dark Mode.chromium.png | 634 | Changed |
react-charting-HeatMapChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-HeatMapChart.Basic RTL.chromium.png | 1354 | Changed |
| react-charting-HeatMapChart.Basic Dark Mode.chromium.png | 1352 | Changed |
| react-charting-HeatMapChart.Basic.chromium.png | 1352 | Changed |
react-charting-HorizontalBarChart 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-HorizontalBarChart.With Axis Dark Mode.chromium.png | 843 | Changed |
| react-charting-HorizontalBarChart.Basic.chromium.png | 929 | Changed |
| react-charting-HorizontalBarChart.Basic Dark Mode.chromium.png | 929 | Changed |
| react-charting-HorizontalBarChart.Basic RTL.chromium.png | 939 | Changed |
| react-charting-HorizontalBarChart.With Axis RTL.chromium.png | 836 | Changed |
| react-charting-HorizontalBarChart.With_Axis.chromium.png | 843 | Changed |
react-charting-PieChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-PieChart.Basic RTL.chromium.png | 478 | Changed |
| react-charting-PieChart.Basic Dark Mode.chromium.png | 474 | Changed |
| react-charting-PieChart.Basic.chromium.png | 474 | Changed |
react-charting-VerticalBarChart 6 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-VerticalBarChart.Basic Secondary Y Axis Dark Mode.chromium.png | 843 | Changed |
| react-charting-VerticalBarChart.Basic - Secondary Y Axis.chromium.png | 843 | Changed |
| react-charting-VerticalBarChart.Basic Secondary Y Axis RTL.chromium.png | 836 | Changed |
| react-charting-VerticalBarChart.Stacked RTL.chromium.png | 836 | Changed |
| react-charting-VerticalBarChart.Stacked.chromium.png | 843 | Changed |
| react-charting-VerticalBarChart.Stacked Dark Mode.chromium.png | 843 | Changed |
There was a problem hiding this comment.
why did so many screenshots change
There was a problem hiding this comment.
We are using different version of d3-color now (as per yarn.lock file). I can see that reason only.
There was a problem hiding this comment.
no we are not. it is mapping to same 3.1.0.
Looks like something else has broken.
There was a problem hiding this comment.
Seems unrelated to my changes. let me take a master pull.
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Jan 15, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.chromium.png | 5 | Changed |
Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.Full Overlay RTL.chromium.png | 1168 | Changed |
|
Pull request demo site: URL |
AtishayMsft
reviewed
Jan 15, 2025
|
Lets start following this naming convention for the PR title. https://www.conventionalcommits.org/en/v1.0.0-beta.2/ |
srmukher
reviewed
Jan 15, 2025
Anush2303
changed the title
mainframev
approved these changes
Jan 16, 2025
AtishayMsft
reviewed
Jan 16, 2025
AtishayMsft
reviewed
Jan 16, 2025
packages/charts/react-charting/src/components/HeatMapChart/HeatMapChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 16, 2025
packages/charts/react-charting/src/components/HeatMapChart/HeatMapChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 16, 2025
| @@ -1,4 +1,5 @@ | |||
| import { create as d3Create, select as d3Select, Selection } from 'd3-selection'; | |||
| import { resolveCSSVariables } from '../../utilities/utilities'; | |||
There was a problem hiding this comment.
dont use relative imports
There was a problem hiding this comment.
I see this pattern at multiple places. Lets start fixing from here.
There was a problem hiding this comment.
okay. But is it correct to use absolute paths?
AtishayMsft
reviewed
Jan 16, 2025
packages/charts/react-charting/src/components/HeatMapChart/HeatMapChart.base.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Related Issue(s)