[Bundle] Simplify profile refresh during bundle execution #4715
+364
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhibf
added
Bug-Performance
fhibf
changed the title
feordin
reviewed
Nov 7, 2024
src/Microsoft.Health.Fhir.CosmosDb/Features/Storage/CosmosFhirDataStore.cs
Show resolved
Hide resolved
feordin
reviewed
Nov 7, 2024
src/Microsoft.Health.Fhir.Shared.Api/Features/Resources/Bundle/BundleHandler.cs
Show resolved
Hide resolved
feordin
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify profile refresh during bundle execution.
In case a bundle contains changes on ValueSet, StructureDefinition and/or CodeSystem, no profile refreshes are executed until the bundle is completed.
This strategy will improve the performance of bundle when handling changes on these resource types.
Bundles were previously delayed due the multiple refreshes and changes on the state of the service.
Related issues
AB#132200
Testing
Testing the improvement, it's noticeable the gain in performance.
With the issue, one of the tests took 160 seconds to execute, and with the fix it only took 2.4 seconds to process the entire bundle.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)