-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not review] New schema with reference separation #4710
Open
SergeyGaluzo
wants to merge
25
commits into
main
Choose a base branch
from
users/sergal/newschemarefsep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* History separation V0 * Forgotten resource * replace current by view * TRUNCATE * HardDelete * delete history v0 * missed 64 and removed dead code from SQL query generator * Removed history from current in merge * Triggers * tests and tran * disable/enable indexes * rollback hard delete and merge * rollback delete invisible history * TRUNCATE -> DELETE * line * leftovers * PK check * Cosmetic * WHERE nanes * Get resources with forced indexes * Removed redundant where * Adding feature flag for raw resource dedupping * Enable invisible history by default * parameters * commit * fixed typo * 65 + more realistic diff * adjusted update trigger * right trigger * next iteration * special chars * Added delete and update * \r * Adding script runner * Added verification * cosmetic * HOLDLOCK hint * removed incorrect comments * RT * lock timeout * 180 and remove empty * no changes in update resource search params * blob rewriter tool * Revert "no changes in update resource search params" This reverts commit b2e0c38. * comment * Generic disable indexes and update search params * Dummy resources * fixes * Dummy records based on surr id * adjust test to filter dummy rows * exclude history and current * Adding PerfTest V-1 * Get asyn wrapper without type string to id function * tool * not exists on data copy * packages back * Added comments. * Correct filtered index on resource current * Added redundant IsHistory=0 to index * deduping * Removed dummy records * pp-p * history clause * deduping * testing parameters * get resource by type and surr id range with many versions * skip large databases * Added calls to fhir * added conflict * max retries = 3 * database pings * examples * reverse * start closer * put logic * Create * Move 65 to 84 * Fixes after merge * Adding RawResources table * change capture tweeks * Test fix * Added MI * inline insert * Repeat on updates
… users/sergal/newschemarefsep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlAdlsStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlStoreClient.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlStoreClient.cs
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.