Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterative Include SQL Simplification #4699

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Iterative Include SQL Simplification #4699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5d6ebf
Add simplificiation for SQL iterative includes
Oct 22, 2024
92a94d8
Finish adding include iterate simplification.
Oct 24, 2024
9cf2e2f
Add unit tests
Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/Microsoft.Health.Fhir.SqlServer.UnitTests/Features/Search/SqlCommandSimplifierTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ public class SqlCommandSimplifierTests
{
private ILogger _logger;

private readonly string _iterativeIncludeStartingQuery = "DECLARE @p0 int = 11\r\nDECLARE @p1 int = 11\r\nDECLARE @p2 int = 100\r\nDECLARE @p3 int = 100\r\nDECLARE @p4 int = 100\r\nDECLARE @p5 int = 100\r\n\r\nSET STATISTICS IO ON;\r\nSET STATISTICS TIME ON;\r\n\r\nDECLARE @FilteredData AS TABLE (T1 smallint, Sid1 bigint, IsMatch bit, IsPartial bit, Row int)\r\n;WITH\r\ncte0 AS\r\n(\r\n SELECT ResourceTypeId AS T1, ResourceSurrogateId AS Sid1\r\n FROM dbo.Resource\r\n WHERE IsHistory = 0\r\n\t AND IsDeleted = 0\r\n\t AND ResourceTypeId = 40\r\n)\r\n,cte1 AS\r\n(\r\n SELECT row_number() OVER (ORDER BY T1 ASC, Sid1 ASC) AS Row, *\r\n FROM\r\n (\r\n\t SELECT DISTINCT TOP (@p0) T1, Sid1, 1 AS IsMatch, 0 AS IsPartial\r\n\t FROM cte0\r\n\t ORDER BY T1 ASC, Sid1 ASC\r\n ) t\r\n)\r\nINSERT INTO @FilteredData SELECT T1, Sid1, IsMatch, IsPartial, Row FROM cte1\r\n;WITH cte1 AS (SELECT * FROM @FilteredData)\r\n,cte2 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 204\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (40)\r\n\t AND EXISTS (SELECT * FROM cte1 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1 AND Row < @p1)\r\n)\r\n,cte3 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte2\r\n)\r\n,cte4 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 404\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (40)\r\n\t AND EXISTS (SELECT * FROM cte1 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte5 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte4\r\n)\r\n,cte6 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 204\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (124)\r\n\t AND EXISTS (SELECT * FROM cte5 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte7 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte6\r\n)\r\n,cte8 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 470\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (44)\r\n\t AND EXISTS (SELECT * FROM cte3 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte9 AS\r\n(\r\n SELECT DISTINCT TOP (@p2) T1, Sid1, IsMatch, CASE WHEN count_big(*) over() > @p3 THEN 1 ELSE 0 END AS IsPartial\r\n FROM cte8\r\n)\r\n,cte10 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 470\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (44)\r\n\t AND EXISTS (SELECT * FROM cte7 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte11 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte10\r\n)\r\n,cte12 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 770\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (71)\r\n\t AND EXISTS (SELECT * FROM cte9 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte13 AS\r\n(\r\n SELECT DISTINCT TOP (@p4) T1, Sid1, IsMatch, CASE WHEN count_big(*) over() > @p5 THEN 1 ELSE 0 END AS IsPartial\r\n FROM cte12\r\n)\r\n,cte14 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 770\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (71)\r\n\t AND EXISTS (SELECT * FROM cte11 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte15 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte14\r\n)\r\n,cte16 AS\r\n(\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte1\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte3 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte3.Sid1 AND cte1.T1 = cte3.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte5 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte5.Sid1 AND cte1.T1 = cte5.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte7 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte7.Sid1 AND cte1.T1 = cte7.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte9 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte9.Sid1 AND cte1.T1 = cte9.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte11 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte11.Sid1 AND cte1.T1 = cte11.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte13 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte13.Sid1 AND cte1.T1 = cte13.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte15 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte15.Sid1 AND cte1.T1 = cte15.T1)\r\n)\r\nSELECT DISTINCT r.ResourceTypeId, r.ResourceId, r.Version, r.IsDeleted, r.ResourceSurrogateId, r.RequestMethod, CAST(IsMatch AS bit) AS IsMatch, CAST(IsPartial AS bit) AS IsPartial, r.IsRawResourceMetaSet, r.SearchParamHash, r.RawResource\r\nFROM dbo.Resource r\r\n JOIN cte16 ON r.ResourceTypeId = cte16.T1 AND r.ResourceSurrogateId = cte16.Sid1\r\nWHERE IsHistory = 0\r\n AND IsDeleted = 0\r\nORDER BY IsMatch DESC, r.ResourceTypeId ASC, r.ResourceSurrogateId ASC\r\n\r\nOPTION (RECOMPILE)\r\n-- execution timeout = 180 sec.";

private readonly string _iterativeIncludeEndingQuery = "DECLARE @p0 int = 11\r\nDECLARE @p1 int = 11\r\nDECLARE @p2 int = 100\r\nDECLARE @p3 int = 100\r\nDECLARE @p4 int = 100\r\nDECLARE @p5 int = 100\r\n\r\nSET STATISTICS IO ON;\r\nSET STATISTICS TIME ON;\r\n\r\nDECLARE @FilteredData AS TABLE (T1 smallint, Sid1 bigint, IsMatch bit, IsPartial bit, Row int)\r\n;WITH\r\ncte0 AS\r\n(\r\n SELECT ResourceTypeId AS T1, ResourceSurrogateId AS Sid1\r\n FROM dbo.Resource\r\n WHERE IsHistory = 0\r\n\t AND IsDeleted = 0\r\n\t AND ResourceTypeId = 40\r\n)\r\n,cte1 AS\r\n(\r\n SELECT row_number() OVER (ORDER BY T1 ASC, Sid1 ASC) AS Row, *\r\n FROM\r\n (\r\n\t SELECT DISTINCT TOP (@p0) T1, Sid1, 1 AS IsMatch, 0 AS IsPartial\r\n\t FROM cte0\r\n\t ORDER BY T1 ASC, Sid1 ASC\r\n ) t\r\n)\r\nINSERT INTO @FilteredData SELECT T1, Sid1, IsMatch, IsPartial, Row FROM cte1\r\n;WITH cte1 AS (SELECT * FROM @FilteredData)\r\n,cte2 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 204\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (40)\r\n\t AND EXISTS (SELECT * FROM cte1 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1 AND Row < @p1)\r\n)\r\n,cte3 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte2\r\n)\r\n,cte4 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 404\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (40)\r\n\t AND EXISTS (SELECT * FROM cte1 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte5 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte4\r\n)\r\n,cte6 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 204\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (124)\r\n\t AND EXISTS (SELECT * FROM cte5 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte7 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte6\r\n)\r\n,cte10 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 470\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (44)\r\n\t AND EXISTS (SELECT * FROM cte7 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1 UNION SELECT * FROM cte3 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte11 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte10\r\n)\r\n,cte14 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 770\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (71)\r\n\t AND EXISTS (SELECT * FROM cte11 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte15 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte14\r\n)\r\n,cte16 AS\r\n(\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte1\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte3 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte3.Sid1 AND cte1.T1 = cte3.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte5 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte5.Sid1 AND cte1.T1 = cte5.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte7 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte7.Sid1 AND cte1.T1 = cte7.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte11 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte11.Sid1 AND cte1.T1 = cte11.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte15 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte15.Sid1 AND cte1.T1 = cte15.T1)\r\n)\r\nSELECT DISTINCT r.ResourceTypeId, r.ResourceId, r.Version, r.IsDeleted, r.ResourceSurrogateId, r.RequestMethod, CAST(IsMatch AS bit) AS IsMatch, CAST(IsPartial AS bit) AS IsPartial, r.IsRawResourceMetaSet, r.SearchParamHash, r.RawResource\r\nFROM dbo.Resource r\r\n JOIN cte16 ON r.ResourceTypeId = cte16.T1 AND r.ResourceSurrogateId = cte16.Sid1\r\nWHERE IsHistory = 0\r\n AND IsDeleted = 0\r\nORDER BY IsMatch DESC, r.ResourceTypeId ASC, r.ResourceSurrogateId ASC\r\n\r\nOPTION (RECOMPILE)\r\n-- execution timeout = 180 sec.";

private readonly string _iterativeIncludeUnchangedQuery = "DECLARE @p0 int = 11\r\nDECLARE @p1 int = 11\r\n\r\nSET STATISTICS IO ON;\r\nSET STATISTICS TIME ON;\r\n\r\nDECLARE @FilteredData AS TABLE (T1 smallint, Sid1 bigint, IsMatch bit, IsPartial bit, Row int)\r\n;WITH\r\ncte0 AS\r\n(\r\n SELECT ResourceTypeId AS T1, ResourceSurrogateId AS Sid1\r\n FROM dbo.Resource\r\n WHERE IsHistory = 0\r\n\t AND IsDeleted = 0\r\n\t AND ResourceTypeId = 40\r\n)\r\n,cte1 AS\r\n(\r\n SELECT row_number() OVER (ORDER BY T1 ASC, Sid1 ASC) AS Row, *\r\n FROM\r\n (\r\n\t SELECT DISTINCT TOP (@p0) T1, Sid1, 1 AS IsMatch, 0 AS IsPartial\r\n\t FROM cte0\r\n\t ORDER BY T1 ASC, Sid1 ASC\r\n ) t\r\n)\r\nINSERT INTO @FilteredData SELECT T1, Sid1, IsMatch, IsPartial, Row FROM cte1\r\n;WITH cte1 AS (SELECT * FROM @FilteredData)\r\n,cte2 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 204\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (40)\r\n\t AND EXISTS (SELECT * FROM cte1 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1 AND Row < @p1)\r\n)\r\n,cte3 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte2\r\n)\r\n,cte4 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 404\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (40)\r\n\t AND EXISTS (SELECT * FROM cte1 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte5 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte4\r\n)\r\n,cte6 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 470\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (44)\r\n\t AND EXISTS (SELECT * FROM cte3 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte7 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte6\r\n)\r\n,cte8 AS\r\n(\r\n SELECT DISTINCT refTarget.ResourceTypeId AS T1, refTarget.ResourceSurrogateId AS Sid1, 0 AS IsMatch\r\n FROM dbo.ReferenceSearchParam refSource\r\n\t JOIN dbo.Resource refTarget ON refSource.ReferenceResourceTypeId = refTarget.ResourceTypeId AND refSource.ReferenceResourceId = refTarget.ResourceId\r\n WHERE refSource.SearchParamId = 770\r\n\t AND refTarget.IsHistory = 0\r\n\t AND refTarget.IsDeleted = 0\r\n\t AND refSource.ResourceTypeId IN (71)\r\n\t AND EXISTS (SELECT * FROM cte7 WHERE refSource.ResourceTypeId = T1 AND refSource.ResourceSurrogateId = Sid1)\r\n)\r\n,cte9 AS\r\n(\r\n SELECT DISTINCT T1, Sid1, IsMatch, 0 AS IsPartial\r\n FROM cte8\r\n)\r\n,cte10 AS\r\n(\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte1\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte3 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte3.Sid1 AND cte1.T1 = cte3.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte5 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte5.Sid1 AND cte1.T1 = cte5.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte7 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte7.Sid1 AND cte1.T1 = cte7.T1)\r\n UNION ALL\r\n SELECT T1, Sid1, IsMatch, IsPartial\r\n FROM cte9 WHERE NOT EXISTS (SELECT * FROM cte1 WHERE cte1.Sid1 = cte9.Sid1 AND cte1.T1 = cte9.T1)\r\n)\r\nSELECT DISTINCT r.ResourceTypeId, r.ResourceId, r.Version, r.IsDeleted, r.ResourceSurrogateId, r.RequestMethod, CAST(IsMatch AS bit) AS IsMatch, CAST(IsPartial AS bit) AS IsPartial, r.IsRawResourceMetaSet, r.SearchParamHash, r.RawResource\r\nFROM dbo.Resource r\r\n JOIN cte10 ON r.ResourceTypeId = cte10.T1 AND r.ResourceSurrogateId = cte10.Sid1\r\nWHERE IsHistory = 0\r\n AND IsDeleted = 0\r\nORDER BY IsMatch DESC, r.ResourceTypeId ASC, r.ResourceSurrogateId ASC\r\n\r\nOPTION (RECOMPILE)\r\n-- execution timeout = 180 sec.";

public SqlCommandSimplifierTests()
{
_logger = Substitute.For<ILogger>();
Expand Down Expand Up @@ -97,5 +103,33 @@ public void GivenACommandThatFailsSimplification_WhenSimplified_ThenNothingIsCha
string actualString = stringBuilder.ToString();
Assert.Equal(expectedString, actualString);
}

[Fact]
public void GivenACommandThatContainsIterativeIncludesWithSharedTypes_WhenSimplified_ThenCtesAreUnioned()
{
string startingString = _iterativeIncludeStartingQuery;
string expectedString = _iterativeIncludeEndingQuery;

IndentedStringBuilder stringBuilder = new IndentedStringBuilder(new StringBuilder(startingString));

SqlCommandSimplifier.CombineIterativeIncludes(stringBuilder, _logger);

string actualString = stringBuilder.ToString();
Assert.Equal(expectedString, actualString);
}

[Fact]
public void GivenACommandThatContainsIterativeIncludesWithoutSharedTypes_WhenSimplified_ThenNothingIsChanged()
{
string startingString = _iterativeIncludeUnchangedQuery;
string expectedString = _iterativeIncludeUnchangedQuery;

IndentedStringBuilder stringBuilder = new IndentedStringBuilder(new StringBuilder(startingString));

SqlCommandSimplifier.CombineIterativeIncludes(stringBuilder, _logger);

string actualString = stringBuilder.ToString();
Assert.Equal(expectedString, actualString);
}
}
}
Loading