Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numeric match and topic tag #72
base: main
Are you sure you want to change the base?
numeric match and topic tag #72
Changes from all commits
abf6c03
77d1103
2fe7095
bd72169
e4cb820
551341a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update comment so it reflects the functionality of the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the class inherits from the original AIME_PIPELINE it will continue to run the rest of the AIME_PIPELINE but with the tagging prompt. For example, this means that it will also try to extract an answer and generate the report. There are two options here: 1) Either to not inherit from AIME_PIPELINE, or 2) Inherit from AIME_PIPELINE but then return only the components you need in the pipeline. For example,
return PipelineConfig(
[
self.data_processing_comp,
self.inference_comp,
self.data_post_processing,
],
self.log_dir,
)
In case 2, also requires changing the answer extractor as the marker is different here.