Suggestion for on-responded on prompts #3981
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrecuenco
force-pushed
the
suggestion-on-responded
branch
from
fb62983
to
1463e9a
Compare
|
|
alexrecuenco
force-pushed
the
suggestion-on-responded
branch
6 times, most recently
from
94d57ab
to
c6c6dd9
Compare
On issue microsoft#3947, relying on the responded flag todecide whether to show the prompt interferes with logic that could be happening either a. Concurrently b. On some middleware c. As part of how we reached the prompt I believe the *intention* is to *not* send a prompt if the validator has already sent a message. This is in fact not explained anywhere and it leads to confusion, and restricts the ability to write concise explanations to users along side a retry. - The default behavior is kept, *except* if a message was sent *before* the validator (Those are not considered as part of the prompt logic). This still runs into concurrency issues. For that, - A static method in Prompt has been added, setRepromptStatus. This allows the user to choose explicitly if the prompt should re-prompt or not. - Added extra tests for the new functionality *only* for the text prompt, since all other prompts reuse that same logic.
alexrecuenco
force-pushed
the
suggestion-on-responded
branch
from
c6c6dd9
to
9fe75c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3947
Description
On issue #3947, relying on the responded flag todecide whether to show the prompt interferes with logic that could be happening either
a. Concurrently
b. On some middleware
c. As part of how we reached the prompt
I believe the intention is to not send a prompt if the validator has already sent a message. This is in fact not explained anywhere and it leads to confusion, and restricts the ability to write concise explanations to users along side a retry.
Specific Changes
Testing