-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DockerCommandLineCodeExecutor support for additional volume mounts, exposed host ports #5383
Merged
ekzhu
merged 12 commits into
microsoft:main
from
andrejpk:apk-add-code-exec-docker-args
Feb 11, 2025
Merged
feat: DockerCommandLineCodeExecutor support for additional volume mounts, exposed host ports #5383
ekzhu
merged 12 commits into
microsoft:main
from
andrejpk:apk-add-code-exec-docker-args
Feb 11, 2025
+68
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5383 +/- ##
==========================================
+ Coverage 75.10% 75.11% +0.01%
==========================================
Files 167 167
Lines 9906 9911 +5
==========================================
+ Hits 7440 7445 +5
Misses 2466 2466
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekzhu
reviewed
Feb 8, 2025
python/packages/autogen-ext/src/autogen_ext/code_executors/docker/_docker_code_executor.py
Show resolved
Hide resolved
…utogen into apk-add-code-exec-docker-args
ekzhu
reviewed
Feb 11, 2025
ekzhu
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following additional configuration options to DockerCommandLineCodeExectutor:
Why are these changes needed?
See linked issue below.
In summary: Enable the agents to:
Related issue number
Closes #5363
Checks